Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging] 🐛 Run Examples / Compare Results has (too many) fails #1501

Open
jsnel opened this issue Jul 14, 2024 · 1 comment
Open

[staging] 🐛 Run Examples / Compare Results has (too many) fails #1501

jsnel opened this issue Jul 14, 2024 · 1 comment
Assignees
Labels
staging Issues found in staging branch Status: Lack of interest Issue went stale | cold | lack of (user) interest Type: Bug Minor issues, non-crashing bug, slowdowns

Comments

@jsnel
Copy link
Member

jsnel commented Jul 14, 2024

Version information

  • pyglotaran version: staging

Describe the bug

A number of attributes are missing in the (result) datasets created from staging, compared to main, resulting in a failing result comparison tests, as can be observed in a recent PR.

Last comparison results action resulting in:
================ 141 failed, 436 passed, 49 warnings in 14.14s =================

A non-exaustive list of issues (to see all, check the actions):

  • missing result attribute: 'weighted_root_mean_square_error'
  • a_matrix missing suffix (e.g. a_matrix_complex1)
  • k_matrix missing suffix (e.g. k_matrix_reduced_complex1)
  • center_dispersion_1 missing (this is a special one, because of past renaming things)
  • DAS missing decay_associated_spectra_complex1
  • Missing coordinate: 'component_mc1' in 'dataset1.nc', data_var 'decay_associated_spectra_mc1'

To Reproduce

Steps to reproduce the behavior:

Open a PR to staging, observe the results of the action: Run Examples / Compare Results (pull_request)

Expected behavior

A smaller number of failing tests (maybe not 0, but a lot smaller than 141).

Tiny numerical differences can be acceptable, but we need to eliminate fails because of missing attributes.

Additional context

Note that we already worked around a lot of issues in the compat module and the examples module itself, ideally we need to do less of that.

Compat modules:

pyglotaran_examples staging changes:

@jsnel jsnel added the Type: Bug Minor issues, non-crashing bug, slowdowns label Jul 14, 2024
@jsnel jsnel changed the title 🐛 [staging] Run Examples / Compare Results has (too many) fails [staging] 🐛 Run Examples / Compare Results has (too many) fails Jul 14, 2024
@jsnel jsnel added the staging Issues found in staging branch label Jul 14, 2024
Copy link

stale bot commented Oct 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Lack of interest Issue went stale | cold | lack of (user) interest label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staging Issues found in staging branch Status: Lack of interest Issue went stale | cold | lack of (user) interest Type: Bug Minor issues, non-crashing bug, slowdowns
Projects
None yet
Development

No branches or pull requests

2 participants