GLPI Inventory Packages / Unable to add execution checks in "command" action

[troloff]

Code of Conduct

• I agree to follow this project's Code of Conduct

Is there an existing issue for this?

• I have searched the existing issues

Version

11.0.4
GLPI Inventory Plugin 1.6.4

Bug description

In GLPI Inventory / Packages, when configuring package actions it is not possible to add execution checks to commands. The "+" button is not working.

Relevant log output

Page URL

No response

Steps To reproduce

• add a package via GLPI Inventory / Package
• configure package actions
• add an action type "command"
• try to add an execution check

Your GLPI setup information

No response

Anything else?

No response

[trasher]

Please open glpi-inventory issues on plugin repository.

[trasher]

I do not reproduce on my instance. Please check browser console logs, there is certainly a javascript error somewhere.

[troloff]

Console says:

Uncaught ReferenceError: plusbutton is not defined
    onclick https://inventory.net.adk.de/plugins/glpiinventory/front/deploypackage.form.php?id=1385:1
deploypackage.form.php:1:1

[troloff]

Also, I have a 404:

GET
https://XX/plugins/glpiinventory/lib/plusbutton.min.js?v=29a3c812afeaab7e390cc521413e7bd80a27b980
[HTTP/2 404  729ms]

root@XX:/var/www/XX/plugins/glpiinventory/public/lib# ls -1
d3
deploy_editsubtype.js
extjs
jquery
lazy.js-0.5.1
mustache.js-2.3.0
nvd3
plusbutton.js
REDIPS_drag
timeslot.js

[trasher]

Also, I have a 404:

GET
https://XX/plugins/glpiinventory/lib/plusbutton.min.js?v=29a3c812afeaab7e390cc521413e7bd80a27b980
[HTTP/2 404  729ms]

OK, this is the issue; it's correctly loaded on my side.

[troloff]

root@XX:/var/www/XX/plugins/glpiinventory# grep -Rn "plusbutton" .
./setup.php:267:            $PLUGIN_HOOKS[Hooks::ADD_JAVASCRIPT]['glpiinventory'][] = "lib/plusbutton" . ($debug_mode ? "" : ".min") . ".js";

When activating debug mode, it works for me, too.

[trasher]

Yes, there are 2 issues:
1- the min file does not exist
2- plugin should check if it exist and use the non minified one when not.

I'm on it.