Update high leverage warning logic

Author: midas-myth

src/components/Synthetics/TradeBox/hooks/useShowHighLeverageWarning.ts

@@ -1,12 +1,20 @@
 import { useCallback, useEffect, useState } from "react";
 
-import { AB_HIGH_LEVERAGE_WARNING_GROUP, AB_HIGH_LEVERAGE_WARNING_PROBABILITY } from "config/ab";
+import {
+  AB_HIGH_LEVERAGE_WARNING_ALTCOIN_LEVERAGE,
+  AB_HIGH_LEVERAGE_WARNING_GROUP,
+  AB_HIGH_LEVERAGE_WARNING_MAJOR_TOKEN_LEVERAGE,
+  AB_HIGH_LEVERAGE_WARNING_PROBABILITY,
+} from "config/ab";
 import { ARBITRUM, AVALANCHE, BOTANIX } from "config/chains";
-import { BASIS_POINTS_DIVISOR_BIGINT } from "config/factors";
 import { getHighLeverageWarningDismissedTimestampKey } from "config/localStorage";
 import { selectAccount, selectChainId } from "context/SyntheticsStateContext/selectors/globalSelectors";
+import { selectIsLeverageSliderEnabled } from "context/SyntheticsStateContext/selectors/settingsSelectors";
 import { selectTradeboxToTokenAddress } from "context/SyntheticsStateContext/selectors/shared/baseSelectors";
-import { selectTradeboxLeverage } from "context/SyntheticsStateContext/selectors/tradeboxSelectors";
+import {
+  selectTradeboxIncreasePositionAmounts,
+  selectTradeboxLeverage,
+} from "context/SyntheticsStateContext/selectors/tradeboxSelectors";
 import { useSelector } from "context/SyntheticsStateContext/utils";
 import { useIsFreshAccountForHighLeverageTrading } from "domain/synthetics/accountStats/useIsFreshAccountForHighLeverageTrading";
 import { useIsAddressInGroup } from "lib/userAnalytics/getIsAddressInGroup";
@@ -18,8 +26,6 @@ const IS_MAJOR_TOKEN_MAP: Record<number, string[]> = {
   [BOTANIX]: ["BTC"],
 };
 
-const MAX_MAJOR_TOKEN_LEVERAGE = 15n * BASIS_POINTS_DIVISOR_BIGINT;
-const MAX_ALTCOIN_LEVERAGE = 10n * BASIS_POINTS_DIVISOR_BIGINT;
 const WAIVE_DISMISSAL_PERIOD_MS = 24 * 60 * 60 * 1000; // 24 hours
 const DISMISSAL_POLL_INTERVAL_MS = 5000;
 
@@ -50,9 +56,14 @@ export function useShowHighLeverageWarning(): {
   const toTokenAddress = useSelector(selectTradeboxToTokenAddress);
   const toTokenSymbol = toTokenAddress ? getToken(chainId, toTokenAddress).symbol : undefined;
   const isMajorToken = toTokenSymbol ? IS_MAJOR_TOKEN_MAP[chainId].includes(toTokenSymbol) : false;
-  const leverage = useSelector(selectTradeboxLeverage);
-
-  const isHighLeverage = isMajorToken ? leverage >= MAX_MAJOR_TOKEN_LEVERAGE : leverage >= MAX_ALTCOIN_LEVERAGE;
+  const isLeverageSliderEnabled = useSelector(selectIsLeverageSliderEnabled);
+  const leverageSliderLeverage = useSelector(selectTradeboxLeverage);
+  const amounts = useSelector(selectTradeboxIncreasePositionAmounts);
+  const leverage = isLeverageSliderEnabled ? leverageSliderLeverage : amounts?.estimatedLeverage ?? 0n;
+
+  const isHighLeverage = isMajorToken
+    ? leverage >= AB_HIGH_LEVERAGE_WARNING_MAJOR_TOKEN_LEVERAGE
+    : leverage >= AB_HIGH_LEVERAGE_WARNING_ALTCOIN_LEVERAGE;
 
   const [dismissedTimestamp, setDismissedTimestamp] = useState(() => {
     if (!account) {

src/config/ab.ts

@@ -1,5 +1,6 @@
 import mapValues from "lodash/mapValues";
 
+import { BASIS_POINTS_DIVISOR_BIGINT } from "./factors";
 import { AB_FLAG_STORAGE_KEY } from "./localStorage";
 
 type AbFlagValue = {
@@ -102,4 +103,6 @@ export function getAbFlagUrlParams(): string {
 // Config for deterministic ab flags based on address
 
 export const AB_HIGH_LEVERAGE_WARNING_GROUP = "alert-high-leverage";
-export const AB_HIGH_LEVERAGE_WARNING_PROBABILITY = 50n;
+export const AB_HIGH_LEVERAGE_WARNING_PROBABILITY = 0.5;
+export const AB_HIGH_LEVERAGE_WARNING_MAJOR_TOKEN_LEVERAGE = 15n * BASIS_POINTS_DIVISOR_BIGINT;
+export const AB_HIGH_LEVERAGE_WARNING_ALTCOIN_LEVERAGE = 10n * BASIS_POINTS_DIVISOR_BIGINT;

src/lib/userAnalytics/getIsAddressInGroup.spec.ts

@@ -4,22 +4,22 @@ import { getIsAddressInGroup } from "./getIsAddressInGroup";
 
 describe("getIsAddressInGroup", () => {
   it("it should be roughly in expected probability", () => {
-    const prefferedProbabilities = [1, 10, 20, 30, 40, 50, 60, 70, 80, 90, 100];
+    const prefferedProbabilities = [0.01, 0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 1.0];
     for (const probability of prefferedProbabilities) {
       const count = 50_000;
-      let yesses = 0;
+      let positiveCount = 0;
       for (let i = 0; i < count; i++) {
         const isInGroup = getIsAddressInGroup({
           address: i.toString(),
-          experimentGroupProbability: BigInt(probability),
+          experimentGroupProbability: probability,
           grouping: "test",
         });
         if (isInGroup) {
-          yesses++;
+          positiveCount++;
         }
       }
 
-      expect(yesses / count).toBeCloseTo(probability / 100);
+      expect(positiveCount / count).toBeCloseTo(probability);
     }
   });
 });

src/lib/userAnalytics/getIsAddressInGroup.ts

@@ -8,14 +8,14 @@ export function getIsAddressInGroup({
 }: {
   address: string;
   /**
-   * 0n-100n meaning 0% - 100%
+   * 0-1 meaning 0% - 100%
    */
-  experimentGroupProbability: bigint;
+  experimentGroupProbability: number;
   grouping: string;
 }): boolean {
   const hash = keccak256(stringToHex(address.toLowerCase() + (salt || "")));
   const twoDigits = BigInt(hash) % 100n;
-  const isInGroup = twoDigits < probability;
+  const isInGroup = twoDigits < BigInt(Math.trunc(probability * 100));
   return isInGroup;
 }
 
@@ -25,7 +25,7 @@ export function useIsAddressInGroup({
   grouping: salt,
 }: {
   address: string | undefined;
-  experimentGroupProbability: bigint;
+  experimentGroupProbability: number;
   grouping: string;
 }) {
   const isInGroup = useMemo(