Skip to content

Commit 03b9f9a

Browse files
committed
MinGW: Remove manual setting of library prefix/suffix (#277)
We no longer need to manually set these suffixes/prefixes as CMake in MSYS2 now knows about Objective C. See msys2/MINGW-packages#20028 See https://gitlab.kitware.com/cmake/cmake/-/merge_requests/9244 See msys2/MINGW-packages#20024 (comment)
1 parent 91cd6c7 commit 03b9f9a

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

CMakeLists.txt

+2-3
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,8 @@ endif()
2121
enable_language(OBJC OBJCXX)
2222

2323
if (MINGW)
24-
set(CMAKE_IMPORT_LIBRARY_SUFFIX ".dll.a")
25-
set(CMAKE_LINK_LIBRARY_SUFFIX "")
26-
set(CMAKE_SHARED_LIBRARY_PREFIX "lib")
24+
# Make sure ObjC++ source code uses the C++ implicit include directories. This is needed, for example, to make sure we use the right
25+
# C++ headers when using clang but linking with libstdc++.
2726
set(CMAKE_OBJCXX_IMPLICIT_INCLUDE_DIRECTORIES ${CMAKE_CXX_IMPLICIT_INCLUDE_DIRECTORIES})
2827
endif ()
2928

0 commit comments

Comments
 (0)