Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

隐藏的问题:err is never used #819

Open
Tiper-In-Github opened this issue Oct 26, 2024 · 1 comment
Open

隐藏的问题:err is never used #819

Tiper-In-Github opened this issue Oct 26, 2024 · 1 comment
Labels

Comments

@Tiper-In-Github
Copy link

Reproduction link

https://github.com/go-admin-team/go-admin

Steps to reproduce

直接启动项目,可在编辑器观察到多处“err is never used”警告。这导致了部分err被忽略,例如:app/other/apis/sys_server_monitor.go:52,如果startTime变量解析失败,但是endTime解析成功,那么这个错误会被忽略(我承认,这是一个小概率会发生的事件)

What is expected?

return error

What is actually happening?

return nil

Environment Info
go-admin 2.1.2
Go 1.23.1
System windows11
Browser Edge 130.0.2849.56 x64
@Tiper-In-Github
Copy link
Author

Tiper-In-Github commented Oct 26, 2024

fix in pr:#816
#816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant