Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] replace kratos metrics with otel metrics #3255

Closed
2 tasks
shenqidebaozi opened this issue Mar 16, 2024 · 3 comments · Fixed by #3256
Closed
2 tasks

[Feature] replace kratos metrics with otel metrics #3255

shenqidebaozi opened this issue Mar 16, 2024 · 3 comments · Fixed by #3256
Labels

Comments

@shenqidebaozi
Copy link
Member

shenqidebaozi commented Mar 16, 2024

The current otel metrics have been officially released, and Kratos currently does not need to continue maintaining custom abstractions.

Requirement:

  • Delete the current metrics interface
  • Implement middleware/metrics using otel metrics

I submitted a PR before #2831, but at that time, the otel metrics feature was incomplete. You can use it as a reference.

Copy link

dosubot bot commented Mar 16, 2024

Based on the context provided, it seems like you're looking to replace the current kratos metrics with otel metrics in the Kratos framework. This is a significant change and would involve a few steps. Here's a general guide on how you might proceed:

  1. Understand the current kratos metrics implementation: As per the context, the kratos metrics functionality is designed to integrate Prometheus metrics collection and reporting into applications built with the Kratos framework. It's important to understand how this is currently implemented in the codebase. You can start by looking at the contrib/metrics/prometheus directory in the Kratos repository.

  2. Understand the otel metrics implementation: Before you can replace the current metrics with otel metrics, you'll need to understand how otel metrics works. Unfortunately, I couldn't find specific information about this in the context provided. You might want to look at the official OpenTelemetry Metrics documentation or any other resources that explain how to use otel metrics.

  3. Delete the current metrics interface: Once you understand both the current and new metrics implementations, you can start making changes to the codebase. This would involve deleting the current metrics interface. The exact steps for this would depend on where and how the metrics interface is used in the Kratos codebase.

  4. Implement middleware/metrics using otel metrics: After deleting the current metrics interface, the next step would be to implement the middleware/metrics using otel metrics. This would involve writing new code that uses the otel metrics to provide the same functionality that the current metrics interface provides.

  5. Refer to PR feat: metrics middleware use otel metrics #2831: You mentioned that there was a previous PR (feat: metrics middleware use otel metrics #2831) related to this. This PR could serve as a good reference for how to implement these changes. You can look at the changes made in this PR and use them as a guide for your own changes.

Please note that these are general steps and the exact process might vary depending on the specifics of the Kratos codebase and the otel metrics implementation. If you need more specific guidance, please provide more details about the otel metrics implementation and how it differs from the current kratos metrics implementation.

Sources

About Dosu

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

@Ccheers
Copy link
Contributor

Ccheers commented Mar 16, 2024

assign me

@kratos-ci-bot
Copy link
Collaborator

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


kill me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants