Fix custom_api_file
with SCons 4.0.1
#1819
Merged
+6
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #1669, I'm getting an error like this with
custom_api_file
:Python `FileNotFoundError` exception
It's looking for the file relative to the godot-cpp directory, rather than relative to the directory where the
scons
command was run.This is with SCons 4.0.1, which is what comes with Ubuntu 22.04, however, if I update to SCons 4.9.1 via pip, then everything works as expected.
I did some testing (debug
print()
statements and all!), and it seems like theconverter=normalize_path
that #1669 added is running, but it doesn't seem to actually affect the value returned byenv.get('custom_api_file')
.This PR removes the
converter
and switches back to callingnormalize_path
directly, and everything works for me.@Ivorforce Does your
variant_dir
stuff still work with this change?