Disable unused parameter warning on functions with keyword pass

[Kazox61]

Describe the project you are working on

Any

Describe the problem or limitation you are having in your project

I have this virtual function:

func _on_physics_process(delta: float) -> void:
	pass

For this i get this warning:
[Ignore]Line 16 (UNUSED_PARAMETER):The parameter "delta" is never used in the function "_on_physics_process()". If this is intended, prefix it with an underscore: "_delta".

When i use the suggestion, after auto-completing the override, i get this:

func _on_physics_process(_delta: float) -> void:

Describe the feature / enhancement and how it helps to overcome the problem or limitation

The warning shouldn't show up when there is the keyword pass in the function body.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

Instead of disabling the warning, we could also remove the _ in the override from the auto-complete.

If this enhancement will not be used often, can it be worked around with a few lines of script?

Is there a reason why this should be core and not an add-on in the asset library?

[UnTabouret]

The guide states :

Prepend a single underscore (_) to virtual methods functions the user must override, private functions, and private variables:

So functions prefixed with an underscore can be non-virtual, private functions that should have this warning enabled.

However I agree that pass should disable this warning

[dalexeev]

I don't think this is a good idea. This warning is already not generated for abstract methods, but otherwise, GDScript can't determine whether you intend a function to be virtual or not. Furthermore, virtual functions don't necessarily contain only pass in their body; for non-void functions, this will be at least return <default value>.

See the following issues for explicit virtual marking:

• Add GDScript support for defining virtual/prototype/must-override methods in base classes #1631
• @override and super #3936
• Add a @final method annotation to GDScript #10500 (comment)
• Introduce an annotation for overridability of GDScript functions #10155
• @virtual tag for documentation comments #10638
• Implement an explicit virtual method mark for GDScript godot#103859
• GDScript: Add an @override annotation for enforcing proper override semantics godot#110133

Currently, you can use one of the following methods to suppress the warning:

1. Use @warning_ignore (or @warning_ignore_start if you have multiple virtual methods).
2. Prefix unused parameters with _.