Regression: Clip Children broken

[jitspoe]

Tested versions

• v4.6.dev.custom_build [5e317ce] (Synced ~3-4 days ago)
• Not reproducible in 4.6 dev 4

System information

Godot v4.4.1.stable - Windows 10 (build 19045) - Multi-window, 2 monitors - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3080 (NVIDIA; 32.0.15.8115) - AMD Ryzen 7 3700X 8-Core Processor (16 threads)

Issue description

Setting the "Clip Children" on a sprite is completely broken.

Before:

After:

Steps to reproduce

• Make a 2D scene.
• Add a sprite (can just drag the default logo image into the scene).
• Add another sprite as a child of that sprite.
• Go to visibility and set "Clip children" to "clip only"
• Note that the child is not clipped. Not as dramatic as my above example, but it flat out doesn't work.

Minimal reproduction project (MRP)

test-clip-children.zip

[AThousandShips]

Can confirm, will bisect

[AThousandShips]

Bisected to:

• Massively optimize canvas 2D rendering by using vertex buffers #112481

CC @stuartcarnie

Edit: We should probably add some kind of testing project for Clip Children, it seems to somewhat regularly be broken

[stuartcarnie]

I've fixed it (this was the original MRP from #102147)