Shader Baker: Fix Linux export warning#112465
Merged
Merged
Conversation
akien-mga
added
bug
platform:linuxbsd
topic:rendering
topic:export
cherrypick:4.5
DarioSamo
reviewed
Nov 19, 2025
DarioSamo
approved these changes
Nov 19, 2025
Contributor
DarioSamo
left a comment
DarioSamo
left a comment
There was a problem hiding this comment.
Other than a minor code nitpick, the changes look good to me as long as get_project_setting works as described.
We now have APIs exactly for this use case of querying project settings for a target platform instead of the host OS. - Fixes godotengine#112462.
akien-mga
force-pushed
the
shader-baker-export-linux
branch
from
464143a to
14734cb
Compare
Contributor
|
Thanks! |
Member
Author
|
Cherry-picked for 4.5.2. |
akien-mga
removed
the
cherrypick:4.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now have APIs exactly for this use case of querying project settings for a target platform instead of the host OS.