Skip to content

Commit 31fde6b

Browse files
committed
feat: Create Ctx.Res API
1 parent 8dbd147 commit 31fde6b

26 files changed

+861
-717
lines changed

app_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -981,8 +981,8 @@ func Test_App_Static_Custom_CacheControl(t *testing.T) {
981981
app := New()
982982

983983
app.Static("/", "./.github", Static{ModifyResponse: func(c Ctx) error {
984-
if strings.Contains(c.GetRespHeader("Content-Type"), "text/html") {
985-
c.Response().Header.Set("Cache-Control", "no-cache, no-store, must-revalidate")
984+
if strings.Contains(c.Res().Get("Content-Type"), "text/html") {
985+
c.Set("Cache-Control", "no-cache, no-store, must-revalidate")
986986
}
987987
return nil
988988
}})

bind_test.go

+27-27
Original file line numberDiff line numberDiff line change
@@ -540,21 +540,21 @@ func Test_Bind_RespHeader(t *testing.T) {
540540
c.Context().Request.SetBody([]byte(``))
541541
c.Context().Request.Header.SetContentType("")
542542

543-
c.Response().Header.Add("id", "1")
544-
c.Response().Header.Add("Name", "John Doe")
545-
c.Response().Header.Add("Hobby", "golang,fiber")
543+
c.Context().Response.Header.Add("id", "1")
544+
c.Context().Response.Header.Add("Name", "John Doe")
545+
c.Context().Response.Header.Add("Hobby", "golang,fiber")
546546
q := new(Header)
547547
require.NoError(t, c.Bind().RespHeader(q))
548548
require.Len(t, q.Hobby, 2)
549549

550-
c.Response().Header.Del("hobby")
551-
c.Response().Header.Add("Hobby", "golang,fiber,go")
550+
c.Context().Response.Header.Del("hobby")
551+
c.Context().Response.Header.Add("Hobby", "golang,fiber,go")
552552
q = new(Header)
553553
require.NoError(t, c.Bind().RespHeader(q))
554554
require.Len(t, q.Hobby, 3)
555555

556556
empty := new(Header)
557-
c.Response().Header.Del("hobby")
557+
c.Context().Response.Header.Del("hobby")
558558
require.NoError(t, c.Bind().Query(empty))
559559
require.Empty(t, empty.Hobby)
560560

@@ -569,13 +569,13 @@ func Test_Bind_RespHeader(t *testing.T) {
569569
No []int64
570570
}
571571

572-
c.Response().Header.Add("id", "2")
573-
c.Response().Header.Add("Name", "Jane Doe")
574-
c.Response().Header.Del("hobby")
575-
c.Response().Header.Add("Hobby", "go,fiber")
576-
c.Response().Header.Add("favouriteDrinks", "milo,coke,pepsi")
577-
c.Response().Header.Add("alloc", "")
578-
c.Response().Header.Add("no", "1")
572+
c.Context().Response.Header.Add("id", "2")
573+
c.Context().Response.Header.Add("Name", "Jane Doe")
574+
c.Context().Response.Header.Del("hobby")
575+
c.Context().Response.Header.Add("Hobby", "go,fiber")
576+
c.Context().Response.Header.Add("favouriteDrinks", "milo,coke,pepsi")
577+
c.Context().Response.Header.Add("alloc", "")
578+
c.Context().Response.Header.Add("no", "1")
579579

580580
h2 := new(Header2)
581581
h2.Bool = true
@@ -594,7 +594,7 @@ func Test_Bind_RespHeader(t *testing.T) {
594594
Name string `respHeader:"name,required"`
595595
}
596596
rh := new(RequiredHeader)
597-
c.Response().Header.Del("name")
597+
c.Context().Response.Header.Del("name")
598598
require.Equal(t, "name is empty", c.Bind().RespHeader(rh).Error())
599599
}
600600

@@ -608,21 +608,21 @@ func Test_Bind_RespHeader_Map(t *testing.T) {
608608
c.Context().Request.SetBody([]byte(``))
609609
c.Context().Request.Header.SetContentType("")
610610

611-
c.Response().Header.Add("id", "1")
612-
c.Response().Header.Add("Name", "John Doe")
613-
c.Response().Header.Add("Hobby", "golang,fiber")
611+
c.Context().Response.Header.Add("id", "1")
612+
c.Context().Response.Header.Add("Name", "John Doe")
613+
c.Context().Response.Header.Add("Hobby", "golang,fiber")
614614
q := make(map[string][]string, 0)
615615
require.NoError(t, c.Bind().RespHeader(&q))
616616
require.Len(t, q["Hobby"], 2)
617617

618-
c.Response().Header.Del("hobby")
619-
c.Response().Header.Add("Hobby", "golang,fiber,go")
618+
c.Context().Response.Header.Del("hobby")
619+
c.Context().Response.Header.Add("Hobby", "golang,fiber,go")
620620
q = make(map[string][]string, 0)
621621
require.NoError(t, c.Bind().RespHeader(&q))
622622
require.Len(t, q["Hobby"], 3)
623623

624624
empty := make(map[string][]string, 0)
625-
c.Response().Header.Del("hobby")
625+
c.Context().Response.Header.Del("hobby")
626626
require.NoError(t, c.Bind().Query(&empty))
627627
require.Empty(t, empty["Hobby"])
628628
}
@@ -789,9 +789,9 @@ func Benchmark_Bind_RespHeader(b *testing.B) {
789789
c.Context().Request.SetBody([]byte(``))
790790
c.Context().Request.Header.SetContentType("")
791791

792-
c.Response().Header.Add("id", "1")
793-
c.Response().Header.Add("Name", "John Doe")
794-
c.Response().Header.Add("Hobby", "golang,fiber")
792+
c.Context().Response.Header.Add("id", "1")
793+
c.Context().Response.Header.Add("Name", "John Doe")
794+
c.Context().Response.Header.Add("Hobby", "golang,fiber")
795795

796796
q := new(ReqHeader)
797797
b.ReportAllocs()
@@ -811,9 +811,9 @@ func Benchmark_Bind_RespHeader_Map(b *testing.B) {
811811
c.Context().Request.SetBody([]byte(``))
812812
c.Context().Request.Header.SetContentType("")
813813

814-
c.Response().Header.Add("id", "1")
815-
c.Response().Header.Add("Name", "John Doe")
816-
c.Response().Header.Add("Hobby", "golang,fiber")
814+
c.Context().Response.Header.Add("id", "1")
815+
c.Context().Response.Header.Add("Name", "John Doe")
816+
c.Context().Response.Header.Add("Hobby", "golang,fiber")
817817

818818
q := make(map[string][]string)
819819
b.ReportAllocs()
@@ -1540,7 +1540,7 @@ func Test_Bind_Must(t *testing.T) {
15401540
rq := new(RequiredQuery)
15411541
c.Context().URI().SetQueryString("")
15421542
err := c.Bind().Must().Query(rq)
1543-
require.Equal(t, StatusBadRequest, c.Response().StatusCode())
1543+
require.Equal(t, StatusBadRequest, c.Context().Response.StatusCode())
15441544
require.Equal(t, "Bad request: name is empty", err.Error())
15451545
}
15461546

client/response_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ func Test_Response_Header(t *testing.T) {
182182

183183
server := startTestServer(t, func(app *fiber.App) {
184184
app.Get("/", func(c fiber.Ctx) error {
185-
c.Response().Header.Add("foo", "bar")
185+
c.Set("foo", "bar")
186186
return c.SendString("helo world")
187187
})
188188
})

0 commit comments

Comments
 (0)