Emoji not rendered on commits view

[carbontwelve]

• Gogs version (or commit ref): 0.11.4.0405
• Git version: n/a
• Operating system: Ubuntu
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gogs.io:
  • Yes, see https://try.gogs.io/c12/emoji-test/commits/master
  • No
  • Not relevant
• Log gist (usually found in log/gogs.log): n/a

Description

I am not sure if this is or isn't related to #3023, however I am running Gogs version 0.11.4.0405 and have noticed that on the commit history page emoji aren't rendered even though the <td> element has the has-emoji class.

Having had a look at gogs.js the implementation of emojify looks to be correct.

Looking at [commits_table.tmpl])(https://github.com/gogits/gogs/blob/9e3c83372f19853ac1dc164e2fcf58d9779ac0f0/templates/repo/commits_table.tmpl#L43) a fix is to place the has-emoji class onto the <span> rather than on the <td>.

I am going to fork and create a pull request the above effect.

[carbontwelve]

The result of my pull request: #4440

Before:

After:

This wouldn't be an issue if the emojify.js lib had pulled in this fix but it appears that project is dead?

[unknwon]

This is claimed to be fixed by merging #4440, please help test on develop branch or https://try.gogs.io.

[carbontwelve]

Confirmed fixed on try.gogs.io

[unknwon]

Mis-click... sorry about any noise.