Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hkdf: Replace nil salt with a slice of a preallocated all zeros buffer #260

Open
wants to merge 4 commits into
base: v2
Choose a base branch
from

Conversation

samiponkanenssh
Copy link

hkdf: Replace nil salt with a slice of a preallocated all zeros buffer. This fixes HKDF when using KeyPair FIPS Provider for OpenSSL 3

Fixes #253

…r. This fixes HKDF when using KeyPair FIPS Provider for OpenSSL 3
@samiponkanenssh samiponkanenssh requested a review from qmuntal March 3, 2025 08:18
Copy link
Collaborator

@qmuntal qmuntal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@qmuntal qmuntal requested review from derekparker and dagood March 3, 2025 08:38
@samiponkanenssh samiponkanenssh requested a review from dagood March 6, 2025 10:20
Copy link
Collaborator

@dagood dagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TLS 1.3 HKDF-Extract with empty salt fails when using the KeyPair FIPS Provider
3 participants