openssl: implement cgoless wrappers for C functions #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdams
force-pushed
the
dev/gadams/cgoless
branch
from
1bff9e1 to
51e901b
Compare
…penssl into dev/gadams/cgoless
qmuntal
approved these changes
Oct 8, 2025
qmuntal
force-pushed
the
dev/gadams/cgoless
branch
from
994a7f6 to
fa14adf
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements cgoless wrappers for OpenSSL C functions to enable building Go applications with OpenSSL support without requiring CGO. This is a significant architectural enhancement that provides an alternative implementation path.
- Adds a new nocgo mode to the mkcgo tool for generating CGO-free wrapper code
- Implements dynamic library loading using syscalls instead of CGO for OpenSSL functions
- Provides platform-specific assembly code for system call handling on AMD64 and ARM64
Reviewed Changes
Copilot reviewed 51 out of 52 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/ossl/zossl_nocgo.go | Generated nocgo wrapper functions that call OpenSSL via syscalls |
| internal/ossl/zossl_cgo.go | Extracted CGO-specific wrapper functions from main file |
| internal/ossl/zossl.go | Refactored to contain only constants and shared utilities |
| internal/ossl/syscall_nocgo_*.go | Platform-specific syscall implementations for nocgo mode |
| internal/ossl/asm_*.s | Assembly trampolines for system call handling |
| internal/ossl/zdl_nocgo.go | Dynamic library loading functions for nocgo mode |
| internal/ossl/errors_nocgo.go | Error handling implementation for nocgo mode |
| internal/ossl/ossl_nocgo.go | Nocgo-specific OpenSSL utility functions |
| internal/mkcgo/*.go | Enhanced mkcgo tool to support nocgo code generation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cgoless wrappers are gated behind a build tag for now and not used in the root package.