Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/test/integration/modfile: TestGovimModReadonly/default failures #68115

Closed
gopherbot opened this issue Jun 21, 2024 · 4 comments
Closed

x/tools/gopls/internal/test/integration/modfile: TestGovimModReadonly/default failures #68115

gopherbot opened this issue Jun 21, 2024 · 4 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/modfile" && test == "TestGovimModReadonly/default"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestGovimModReadonly/default
goroutine profile: total 7
1 @ 0x45748 0x897cc 0x21c0cc 0x21bec4 0x219540 0xa6cb58 0xa6c7bc 0x166ef0 0x93c24
#	0x21c0cb	runtime/pprof.writeRuntimeProfile+0xeb						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:773
#	0x21bec3	runtime/pprof.writeGoroutine+0x73						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:732
#	0x21953f	runtime/pprof.(*Profile).WriteTo+0x16f						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:374
#	0xa6cb57	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1.1+0x77	/home/swarming/.swarming/w/ir/x/w/targetrepo2654475082/gopls/internal/test/integration/runner.go:198
#	0xa6c7bb	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1+0xcab	/home/swarming/.swarming/w/ir/x/w/targetrepo2654475082/gopls/internal/test/integration/runner.go:252
#	0x166eef	testing.tRunner+0x10f								/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1690

...
#	0xac323		syscall.wait4+0x73						/home/swarming/.swarming/w/ir/x/w/goroot/src/syscall/zsyscall_openbsd_ppc64.go:43
#	0xa96af		syscall.Wait4+0x4f						/home/swarming/.swarming/w/ir/x/w/goroot/src/syscall/syscall_bsd.go:144
#	0xdf0d7		os.(*Process).pidWait+0xc7					/home/swarming/.swarming/w/ir/x/w/goroot/src/os/exec_unix.go:70
#	0xdefc7		os.(*Process).wait+0x37						/home/swarming/.swarming/w/ir/x/w/goroot/src/os/exec_unix.go:30
#	0x1b4033	os.(*Process).Wait+0x53						/home/swarming/.swarming/w/ir/x/w/goroot/src/os/exec.go:358
#	0x1b4028	os/exec.(*Cmd).Wait+0x48					/home/swarming/.swarming/w/ir/x/w/goroot/src/os/exec/exec.go:901
#	0x34a2ef	golang.org/x/tools/internal/gocommand.runCmdContext.func4+0x2f	/home/swarming/.swarming/w/ir/x/w/targetrepo2654475082/internal/gocommand/invoke.go:382

    runner.go:199: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: <nil>; removing files: unlinkat /home/swarming/.swarming/w/ir/x/t/gopls-test-2340774389/TestGovimModReadonly/default: directory not empty
--- FAIL: TestGovimModReadonly/default (34.97s)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 21, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/modfile" && test == "TestGovimModReadonly/default"
2024-06-21 16:27 x_tools-gotip-openbsd-ppc64 tools@8a45e6cd go@20112941 x/tools/gopls/internal/test/integration/modfile.TestGovimModReadonly/default (log) 
=== RUN   TestGovimModReadonly/default
goroutine profile: total 7
1 @ 0x45748 0x897cc 0x21c0cc 0x21bec4 0x219540 0xa6cb58 0xa6c7bc 0x166ef0 0x93c24
#	0x21c0cb	runtime/pprof.writeRuntimeProfile+0xeb						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:773
#	0x21bec3	runtime/pprof.writeGoroutine+0x73						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:732
#	0x21953f	runtime/pprof.(*Profile).WriteTo+0x16f						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:374
#	0xa6cb57	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1.1+0x77	/home/swarming/.swarming/w/ir/x/w/targetrepo2654475082/gopls/internal/test/integration/runner.go:198
#	0xa6c7bb	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1+0xcab	/home/swarming/.swarming/w/ir/x/w/targetrepo2654475082/gopls/internal/test/integration/runner.go:252
#	0x166eef	testing.tRunner+0x10f								/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1690

...
#	0xac323		syscall.wait4+0x73						/home/swarming/.swarming/w/ir/x/w/goroot/src/syscall/zsyscall_openbsd_ppc64.go:43
#	0xa96af		syscall.Wait4+0x4f						/home/swarming/.swarming/w/ir/x/w/goroot/src/syscall/syscall_bsd.go:144
#	0xdf0d7		os.(*Process).pidWait+0xc7					/home/swarming/.swarming/w/ir/x/w/goroot/src/os/exec_unix.go:70
#	0xdefc7		os.(*Process).wait+0x37						/home/swarming/.swarming/w/ir/x/w/goroot/src/os/exec_unix.go:30
#	0x1b4033	os.(*Process).Wait+0x53						/home/swarming/.swarming/w/ir/x/w/goroot/src/os/exec.go:358
#	0x1b4028	os/exec.(*Cmd).Wait+0x48					/home/swarming/.swarming/w/ir/x/w/goroot/src/os/exec/exec.go:901
#	0x34a2ef	golang.org/x/tools/internal/gocommand.runCmdContext.func4+0x2f	/home/swarming/.swarming/w/ir/x/w/targetrepo2654475082/internal/gocommand/invoke.go:382

    runner.go:199: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: <nil>; removing files: unlinkat /home/swarming/.swarming/w/ir/x/t/gopls-test-2340774389/TestGovimModReadonly/default: directory not empty
--- FAIL: TestGovimModReadonly/default (34.97s)

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jun 21, 2024
@gopherbot gopherbot added this to the Unreleased milestone Jun 21, 2024
@gabyhelp
Copy link

Similar Issues

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/modfile" && test == "TestGovimModReadonly/default"
2024-06-24 03:50 x_tools-go1.23-openbsd-amd64 tools@47bd819e release-branch.go1.23@7dff7439 x/tools/gopls/internal/test/integration/modfile.TestGovimModReadonly/default (log) 
=== RUN   TestGovimModReadonly/default
goroutine profile: total 5
1 @ 0x434011 0x47309d 0x5ff551 0x5ff385 0x5fc3ab 0xe95870 0xe954fa 0x547df4 0x47cfc1
#	0x5ff550	runtime/pprof.writeRuntimeProfile+0xb0						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:773
#	0x5ff384	runtime/pprof.writeGoroutine+0x44						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:732
#	0x5fc3aa	runtime/pprof.(*Profile).WriteTo+0x14a						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:374
#	0xe9586f	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1.1+0x6f	/home/swarming/.swarming/w/ir/x/w/targetrepo1504192603/gopls/internal/test/integration/runner.go:198
#	0xe954f9	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1+0xeb9	/home/swarming/.swarming/w/ir/x/w/targetrepo1504192603/gopls/internal/test/integration/runner.go:252
#	0x547df3	testing.tRunner+0xf3								/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1690

...

1 @ 0x4740ee 0x40b4dc 0x40b0b2 0x6ce567 0x47cfc1
#	0x6ce566	golang.org/x/tools/gopls/internal/protocol.LogEvent.func1.1+0x46	/home/swarming/.swarming/w/ir/x/w/targetrepo1504192603/gopls/internal/protocol/context.go:47

1 @ 0x4740ee 0x478725 0x84b885 0x47cfc1
#	0x478724	time.Sleep+0xe4						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/time.go:285
#	0x84b884	golang.org/x/tools/gopls/internal/filecache.gc+0x124	/home/swarming/.swarming/w/ir/x/w/targetrepo1504192603/gopls/internal/filecache/filecache.go:443

    runner.go:199: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: <nil>; removing files: unlinkat /home/swarming/.swarming/w/ir/x/t/gopls-test-2271365929/TestGovimModReadonly/default: directory not empty
--- FAIL: TestGovimModReadonly/default (33.84s)

— watchflakes

@findleyr
Copy link
Member

Closing as a dupe of #68087.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Jun 25, 2024
@findleyr findleyr removed this from Test Flakes Jun 25, 2024
This was referenced Jun 26, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@gopherbot @findleyr @gabyhelp