Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go/internal/modfetch/codehost: test fails with git 2.47.1 [1.23 backport] #71263

Closed
gopherbot opened this issue Jan 14, 2025 · 2 comments
Closed

cmd/go/internal/modfetch/codehost: test fails with git 2.47.1 [1.23 backport] #71263

gopherbot opened this issue Jan 14, 2025 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go
Milestone
Go1.23.6

Comments

@gopherbot
Copy link
Contributor

@ianlancetaylor requested issue #71261 to be considered for backport to the next 1.23 minor release.

@gopherbot Please open backport issues

This test is failing with older versions of Go, presumably because of a newer versions of git. We should backport the fix to supported versions, so that people using older Go versions don't complain when the update to a newer version of git.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jan 14, 2025
@gopherbot gopherbot mentioned this issue Jan 14, 2025
Closed
@gopherbot gopherbot added this to the Go1.23.5 milestone Jan 14, 2025
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/642696 mentions this issue: [release-branch.go1.23] cmd/go/internal/modfetch: do not trust server to send all tags in shallow fetch

@dmitshur dmitshur added the GoCommand cmd/go label Jan 14, 2025
@matloob matloob added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Jan 15, 2025
@gopherbot gopherbot modified the milestones: Go1.23.5, Go1.23.6 Jan 16, 2025
gopherbot pushed a commit that referenced this issue Jan 17, 2025
@rsc @mknyszek
[release-branch.go1.23] cmd/go/internal/modfetch: do not trust server…
ab44565 
… to send all tags in shallow fetch

Newer git versions (at least git 2.47.1) do not send all the matching tags
for a shallow fetch of a specific hash anymore. The go command assumes
that git servers do this. Since that assumption is broken, use the local
copy of the remote refs list to augment the tags sent by the server.
This makes the cmd/go/internal/modfetch tests pass again with newer git.

For #71261
Fixes #71263

Change-Id: I9fd4f3fd7beeb68a522938599f8f3acd887d0b26
Reviewed-on: https://go-review.googlesource.com/c/go/+/642437
Reviewed-by: Michael Matloob <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Auto-Submit: Russ Cox <[email protected]>
(cherry picked from commit bd80d89)
Reviewed-on: https://go-review.googlesource.com/c/go/+/642696
Reviewed-by: Michael Knyszek <[email protected]>
Reviewed-by: Russ Cox <[email protected]>
@gopherbot
Copy link
Contributor Author

Closed by merging CL 642696 (commit ab44565) to release-branch.go1.23.

mpminardi pushed a commit to tailscale/go that referenced this issue Jan 28, 2025
@rsc @mpminardi
[release-branch.go1.23] cmd/go/internal/modfetch: do not trust server…
9193e3c 
… to send all tags in shallow fetch

Newer git versions (at least git 2.47.1) do not send all the matching tags
for a shallow fetch of a specific hash anymore. The go command assumes
that git servers do this. Since that assumption is broken, use the local
copy of the remote refs list to augment the tags sent by the server.
This makes the cmd/go/internal/modfetch tests pass again with newer git.

For golang#71261
Fixes golang#71263

Change-Id: I9fd4f3fd7beeb68a522938599f8f3acd887d0b26
Reviewed-on: https://go-review.googlesource.com/c/go/+/642437
Reviewed-by: Michael Matloob <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Auto-Submit: Russ Cox <[email protected]>
(cherry picked from commit bd80d89)
Reviewed-on: https://go-review.googlesource.com/c/go/+/642696
Reviewed-by: Michael Knyszek <[email protected]>
Reviewed-by: Russ Cox <[email protected]>
yangjuncode pushed a commit to yangjuncode/go that referenced this issue Feb 13, 2025
@rsc @yangjuncode
[release-branch.go1.23] cmd/go/internal/modfetch: do not trust server…
adbf4fa 
… to send all tags in shallow fetch

Newer git versions (at least git 2.47.1) do not send all the matching tags
for a shallow fetch of a specific hash anymore. The go command assumes
that git servers do this. Since that assumption is broken, use the local
copy of the remote refs list to augment the tags sent by the server.
This makes the cmd/go/internal/modfetch tests pass again with newer git.

For golang#71261
Fixes golang#71263

Change-Id: I9fd4f3fd7beeb68a522938599f8f3acd887d0b26
Reviewed-on: https://go-review.googlesource.com/c/go/+/642437
Reviewed-by: Michael Matloob <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Auto-Submit: Russ Cox <[email protected]>
(cherry picked from commit bd80d89)
Reviewed-on: https://go-review.googlesource.com/c/go/+/642696
Reviewed-by: Michael Knyszek <[email protected]>
Reviewed-by: Russ Cox <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go
Projects
None yet
Milestone
Go1.23.6
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @matloob