x/tools/gopls: Rename: crash (in satisfy) with ill-typed input

[adonovan]

#!stacks
"runtime.panicdottypeI" && "refactor/satisfy.(*Finder).exprN:+1"

Issue created by stacks.

Missing entry in types.Info.Types in ill-typed code. Fundamentally it's the same issue as #71657, but the specific failure is distinct. The resolution is the same: wait for #70638.

This stack zv8odw was reported by telemetry:

• crash/crash
• runtime.gopanic:+69
• runtime.panicdottypeE:=275
• runtime.panicdottypeI:+5
• golang.org/x/tools/refactor/satisfy.(*Finder).exprN:+1
• golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+35
• golang.org/x/tools/refactor/satisfy.(*Finder).stmt:+90
• golang.org/x/tools/refactor/satisfy.(*Finder).Find:+19
• golang.org/x/tools/gopls/internal/golang.(*renamer).satisfy:+27
• golang.org/x/tools/gopls/internal/golang.(*renamer).checkMethod:+178
• golang.org/x/tools/gopls/internal/golang.(*renamer).check:+16
• golang.org/x/tools/gopls/internal/golang.renameObjects:+24
• golang.org/x/tools/gopls/internal/golang.renameOrdinary:+99
• golang.org/x/tools/gopls/internal/golang.Rename:+24
• golang.org/x/tools/gopls/internal/server.(*server).Rename:+17
• golang.org/x/tools/gopls/internal/protocol.serverDispatch:+489
• golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.ServerHandler.func3:+5
• golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.handshaker.func4:+52

golang.org/x/tools/[email protected] go1.23.4 windows/amd64 vscode (1)

[gabyhelp]

Related Issues

• x/tools/gopls: Rename: "unexpected composite literal type %T: %v" panic in satisfy.(*Finder).Find #71538
• x/tools/gopls: Rename: "no type for %T" panic in satisfy #71572
• x/tools/gopls: Rename: missing type for selector in satisfy.(*Finder).expr #71657
• x/tools/gopls: Rename: type assertion panics in renameImports #71656
• x/tools/gopls: Rename: crash due to Info.Defs[id]=nil bug in checkStructField #70968
• x/tools/gopls: crash when renaming in a package using builtins with type parameters #52940 (closed)
• x/tools/gopls: crash during renaming #53277 (closed)
• x/tools/gopls: "edit does not belong to syntax of package %q" bug in golang.Rename #70049
• x/tools/gopls: Completion: failed type assertion in completer.item #71044 (closed)
• x/tools/gopls: nil pointer on rename #32974 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}