Skip to content

Commit 5dab416

Browse files
dotchevbradfitz
authored andcommitted
Clarify that client credentials are not passed in the URL
The term "query parameters" suggested that the credentials are passed in the URL which is insecure and is actually not true as the credentials are passed in the request body. See https://github.com/golang/oauth2/blob/36a7019397c4c86cf59eeab3bc0d188bac444277/internal/token.go#L196 Change-Id: Id0a83f8d317fed30e18310b30860000109dafe88 GitHub-Last-Rev: 3961bc9 GitHub-Pull-Request: #358 Reviewed-on: https://go-review.googlesource.com/c/157877 Reviewed-by: Brad Fitzpatrick <[email protected]>
1 parent 36a7019 commit 5dab416

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

oauth2.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ var NoContext = context.TODO()
3131
// which doesn't support the HTTP Basic authentication
3232
// scheme to authenticate with the authorization server.
3333
// Once a server is registered, credentials (client_id and client_secret)
34-
// will be passed as query parameters rather than being present
34+
// will be passed as parameters in the request body rather than being present
3535
// in the Authorization header.
3636
// See https://code.google.com/p/goauth2/issues/detail?id=31 for background.
3737
func RegisterBrokenAuthHeaderProvider(tokenURL string) {

0 commit comments

Comments
 (0)