We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
1 parent 738f4b2 commit 773b2e3Copy full SHA for 773b2e3
internal/crashmonitor/monitor_test.go
@@ -89,7 +89,13 @@ func TestViaStderr(t *testing.T) {
89
"runtime.goexit:--"
90
91
if !crashmonitor.Supported() { // !go1.23
92
- // Before go1.23, the traceback excluded PCs for inlined frames.
+ // Traceback excludes PCs for inlined frames. Before go1.23
93
+ // (https://go.dev/cl/571798 specifically), passing the set of
94
+ // PCs in the traceback to runtime.CallersFrames, would report
95
+ // only the innermost inlined frame and none of the inline
96
+ // "callers".
97
+ //
98
+ // Thus, here we must drop the caller of the inlined frame.
99
want = strings.ReplaceAll(want, "golang.org/x/telemetry/internal/crashmonitor_test.child:+2\n", "")
100
}
101
0 commit comments