term: allow multi-line bracketed paste to not create single line with verbatim LFs #21

ldemailly · 2025-07-12T00:13:52Z

Treat "\n" (LF) like "Enter" (CR)

Avoids that when pasting 3 lines
(with a terminal like kitty, ghostty, alacritty that do not change the clipboard
in bracketed paste mode)
it turns into 1 prompt looking like:

Test> line one
..............line.two
......................line.three

Fixes golang/go#74600

gopherbot · 2025-07-12T00:23:26Z

This PR (HEAD: 76633e0) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/term/+/687755.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-07-12T00:30:21Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/687755.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-12T00:37:23Z

This PR (HEAD: 48ea529) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/term/+/687755.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-07-12T00:51:04Z

Message from Laurent Demailly:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/687755.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-12T00:57:52Z

This PR (HEAD: bc5cb00) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/term/+/687755.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

…new line content

gopherbot · 2025-07-14T00:33:01Z

This PR (HEAD: 3d202e8) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/term/+/687755.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-07-15T21:24:35Z

Message from Michael Pratt:

Patch Set 8: Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/687755.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-15T21:24:36Z

Message from Go LUCI:

Patch Set 8:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-07-15T21:12:59Z","revision":"8dda9b9326926f8c4dd2e14350cdb5a2c78e1583"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/687755.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-15T21:24:36Z

Message from Michael Pratt:

Patch Set 8: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/687755.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-15T21:24:37Z

Message from Go LUCI:

Patch Set 8:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/687755.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-15T21:24:37Z

Message from Go LUCI:

Patch Set 8: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/687755.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-15T21:39:20Z

Message from Laurent Demailly:

Patch Set 8:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/687755.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-15T21:39:20Z

Message from Laurent Demailly:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/687755.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-16T16:09:36Z

This PR (HEAD: 518f25b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/term/+/687755.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Squashed commit of the following: commit 3d202e8 Author: Laurent Demailly <[email protected]> Date: Sun Jul 13 17:27:48 2025 -0700 Handle CR+LF: consume LF after CR, to avoid empty extra lines in dos new line content commit bc5cb00 Author: Laurent Demailly <[email protected]> Date: Fri Jul 11 17:57:31 2025 -0700 keyLF is as much of a key as keyCtrlD so removing the comment commit 48ea529 Author: Laurent Demailly <[email protected]> Date: Fri Jul 11 17:36:03 2025 -0700 missed a spot commit 76633e0 Author: Laurent Demailly <[email protected]> Date: Fri Jul 11 16:57:45 2025 -0700 Allow multi-line bracketed paste to not create single line with LF entry

gopherbot · 2025-07-16T17:19:44Z

Message from Michael Pratt:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/687755.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-16T17:42:58Z

Message from Laurent Demailly:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/687755.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-16T17:43:12Z

This PR (HEAD: cb5628d) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/term/+/687755.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-07-16T18:05:17Z

This PR (HEAD: 0cf26df) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/term/+/687755.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Allow multi-line bracketed paste to not create single line with LF entry

76633e0

ldemailly mentioned this pull request Jul 12, 2025

don't turn on bracketed paste mode by default, expose the option (because of LF, see comments) fortio/terminal#127

Closed

ldemailly changed the title ~~term: Allow multi-line bracketed paste to not create single line with LF entry~~ term: allow multi-line bracketed paste to not create single line with LF entry Jul 12, 2025

ldemailly marked this pull request as draft July 12, 2025 00:30

missed a spot

48ea529

ldemailly marked this pull request as ready for review July 12, 2025 00:38

keyLF is as much of a key as keyCtrlD so removing the comment

bc5cb00

ldemailly mentioned this pull request Jul 12, 2025

Adding LastWasPaste() bool and using the x/term multiline paste fix PR (from fork) fortio/terminal#128

Merged

Handle CR+LF: consume LF after CR, to avoid empty extra lines in dos …

3d202e8

…new line content

ldemailly changed the title ~~term: allow multi-line bracketed paste to not create single line with LF entry~~ term: allow multi-line bracketed paste to not create single line with LF entries Jul 14, 2025

ldemailly changed the title ~~term: allow multi-line bracketed paste to not create single line with LF entries~~ term: allow multi-line bracketed paste to not create single line with verbatim LFs Jul 14, 2025

Merge branch 'golang:master' into bracketed_new_line

518f25b

Adding tests

cb5628d

Clarify limitation/corner case of CRLF in test

0cf26df

term: allow multi-line bracketed paste to not create single line with verbatim LFs #21

Are you sure you want to change the base?

term: allow multi-line bracketed paste to not create single line with verbatim LFs #21

Conversation

ldemailly commented Jul 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Jul 12, 2025

Uh oh!

gopherbot commented Jul 12, 2025

Uh oh!

gopherbot commented Jul 12, 2025

Uh oh!

gopherbot commented Jul 12, 2025

Uh oh!

gopherbot commented Jul 12, 2025

Uh oh!

gopherbot commented Jul 14, 2025

Uh oh!

gopherbot commented Jul 15, 2025

Uh oh!

gopherbot commented Jul 15, 2025

Uh oh!

gopherbot commented Jul 15, 2025

Uh oh!

gopherbot commented Jul 15, 2025

Uh oh!

gopherbot commented Jul 15, 2025

Uh oh!

gopherbot commented Jul 15, 2025

Uh oh!

gopherbot commented Jul 15, 2025

Uh oh!

gopherbot commented Jul 16, 2025

Uh oh!

gopherbot commented Jul 16, 2025

Uh oh!

gopherbot commented Jul 16, 2025

Uh oh!

gopherbot commented Jul 16, 2025

Uh oh!

gopherbot commented Jul 16, 2025

Uh oh!

Uh oh!

ldemailly commented Jul 12, 2025 •

edited

Loading