internal/lsp: run analyses despite some errors

stamblerre · stamblerre · commit 08bd53a4b4c4 · 2019-05-28T20:25:02.000Z
Updates golang/go#32247 Change-Id: Id474e62ea70676c782eb49dddebd64d7f274d2cf Reviewed-on: https://go-review.googlesource.com/c/tools/+/179218 Run-TryBot: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>
diff --git a/internal/lsp/source/analysis.go b/internal/lsp/source/analysis.go
@@ -158,7 +158,7 @@ func (act *Action) execOnce(ctx context.Context, fset *token.FileSet) error {
 	}
 	act.pass = pass
 
-	if len(act.Pkg.GetErrors()) > 0 && !pass.Analyzer.RunDespiteErrors {
+	if act.Pkg.IsIllTyped() && !pass.Analyzer.RunDespiteErrors {
 		act.err = fmt.Errorf("analysis skipped due to errors in package: %v", act.Pkg.GetErrors())
 	} else {
 		act.result, act.err = pass.Analyzer.Run(pass)

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,7 @@ func (act Action) execOnce(ctx context.Context, fset token.FileSet) error {`
`158`	`158`	`}`
`159`	`159`	`act.pass = pass`
`160`	`160`
`161`		`- if len(act.Pkg.GetErrors()) > 0 && !pass.Analyzer.RunDespiteErrors {`
	`161`	`+ if act.Pkg.IsIllTyped() && !pass.Analyzer.RunDespiteErrors {`
`162`	`162`	`act.err = fmt.Errorf("analysis skipped due to errors in package: %v", act.Pkg.GetErrors())`
`163`	`163`	`} else {`
`164`	`164`	`act.result, act.err = pass.Analyzer.Run(pass)`