diff --git a/pkg/lint/lintersdb/manager.go b/pkg/lint/lintersdb/manager.go index 7cc64e588e0f..f05141d6dd46 100644 --- a/pkg/lint/lintersdb/manager.go +++ b/pkg/lint/lintersdb/manager.go @@ -851,8 +851,7 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config { WithSince("v1.38.0"). WithPresets(linter.PresetStyle). WithLoadForGoAnalysis(). - WithURL("https://github.com/sanposhiho/wastedassign"). - WithNoopFallback(m.cfg), + WithURL("https://github.com/sanposhiho/wastedassign"), linter.NewConfig(golinters.NewWhitespace(whitespaceCfg)). WithSince("v1.19.0"). diff --git a/test/testdata/sqlclosecheck.go b/test/testdata/sqlclosecheck.go index 6bbe32914364..254bb3d94146 100644 --- a/test/testdata/sqlclosecheck.go +++ b/test/testdata/sqlclosecheck.go @@ -16,7 +16,6 @@ var ( ) func rowsCorrectDeferBlock() { - rows, err := db.QueryContext(ctx, "SELECT name FROM users WHERE age=?", age) if err != nil { log.Fatal(err) @@ -91,6 +90,13 @@ func rowsMissingClose() { log.Printf("%s are %d years old", strings.Join(names, ", "), age) } +func rowsMissingCloseG[T ~int64](db *sql.DB, a T) { + rows, _ := db.Query("select id from tb") // want "Rows/Stmt was not closed" + for rows.Next() { + // ... + } +} + func rowsNonDeferClose() { rows, err := db.QueryContext(ctx, "SELECT name FROM users WHERE age=?", age) if err != nil { diff --git a/test/testdata/wastedassign.go b/test/testdata/wastedassign.go index 714f3a6382a7..041b0f40bcbb 100644 --- a/test/testdata/wastedassign.go +++ b/test/testdata/wastedassign.go @@ -117,6 +117,18 @@ func mugen() { return } +func mugenG[T ~int](hoge T) { + var i int + for { + hoge = 5 // want "assigned to hoge, but reassigned without using the value" + // break + } + + println(i) + println(hoge) + return +} + func noMugen() { var i int var hoge int