Skip to content

fix: check if exists before adding item to content_types #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renbaoshuo wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: check if exists before adding item to content_types #74

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f8f3cb
fix: check if exists before adding item to content_types
renbaoshuo Aug 8, 2025
2965f07
fix: remove "slices" package import
renbaoshuo Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions docx/contentType.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,28 @@ type Override struct {
}

func (c *ContentTypes) AddExtension(extension, contentType string) error {
for _, d := range c.Default {
if d.Extension == extension {
// If the extension already exists, skip adding it again
return nil
}
}

c.Default = append(c.Default, Default{
Extension: extension,
ContentType: contentType,
})

return nil
}

func (c *ContentTypes) AddOverride(partName, contentType string) error {
for _, o := range c.Override {
if o.PartName == partName {
// If the part already exists, skip adding it again
return nil
}
}

c.Override = append(c.Override, Override{
PartName: partName,
ContentType: contentType,
Expand All @@ -43,9 +56,7 @@ func (c *ContentTypes) AddOverride(partName, contentType string) error {
}

func MIMEFromExt(extension string) (string, error) {
if strings.HasPrefix(extension, ".") {
extension = strings.TrimPrefix(extension, ".")
}
extension = strings.TrimPrefix(extension, ".")

switch extension {
case "rels":
Expand Down