Skip to content

Commit 5f69d8b

Browse files
jckingcopybara-github
authored andcommitted
Use return-by-address overload in comprehension next
PiperOrigin-RevId: 738970926
1 parent e249db7 commit 5f69d8b

File tree

1 file changed

+9
-14
lines changed

1 file changed

+9
-14
lines changed

eval/eval/comprehension_step.cc

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -650,11 +650,9 @@ absl::Status ComprehensionNextStep::Evaluate1(ExecutionFrame* frame) const {
650650
current_value =
651651
frame->attribute_utility().CreateUnknownSet(iter_trail.attribute());
652652
} else {
653-
CEL_ASSIGN_OR_RETURN(
654-
current_value,
655-
iter_range_list.Get(static_cast<size_t>(next_index),
656-
frame->descriptor_pool(), frame->message_factory(),
657-
frame->arena()));
653+
CEL_RETURN_IF_ERROR(iter_range_list.Get(
654+
static_cast<size_t>(next_index), frame->descriptor_pool(),
655+
frame->message_factory(), frame->arena(), &current_value));
658656
}
659657

660658
// pop loop step
@@ -757,11 +755,9 @@ absl::Status ComprehensionNextStep::Evaluate2(ExecutionFrame* frame) const {
757755
current_iter_var = frame->attribute_utility().CreateUnknownSet(
758756
iter_range_trail.attribute());
759757
} else {
760-
CEL_ASSIGN_OR_RETURN(
761-
current_iter_var,
762-
iter_range_list.Get(static_cast<size_t>(next_index),
763-
frame->descriptor_pool(), frame->message_factory(),
764-
frame->arena()));
758+
CEL_RETURN_IF_ERROR(iter_range_list.Get(
759+
static_cast<size_t>(next_index), frame->descriptor_pool(),
760+
frame->message_factory(), frame->arena(), &current_iter_var));
765761
}
766762

767763
AttributeTrail iter2_range_trail;
@@ -780,10 +776,9 @@ absl::Status ComprehensionNextStep::Evaluate2(ExecutionFrame* frame) const {
780776
current_iter_var2 = frame->attribute_utility().CreateUnknownSet(
781777
iter2_range_trail.attribute());
782778
} else {
783-
CEL_ASSIGN_OR_RETURN(
784-
current_iter_var2,
785-
iter2_range_map->Get(current_iter_var, frame->descriptor_pool(),
786-
frame->message_factory(), frame->arena()));
779+
CEL_RETURN_IF_ERROR(iter2_range_map->Get(
780+
current_iter_var, frame->descriptor_pool(), frame->message_factory(),
781+
frame->arena(), &current_iter_var2));
787782
}
788783
} else {
789784
iter2_range_trail = iter_range_trail;

0 commit comments

Comments
 (0)