now using ansible stat to check for file existence on localhost. using "become: true" only where necesssary

Author: jkstill

Diff for: check-oracle.sh

@@ -115,7 +115,7 @@ do
             ;;
 
         --ahf-install)
-            ORACLE_SID='NOOP'
+            : ${ORACLE_SID=:'NOOP'}
             AHF_UNINSTALL=1
             AHF_INSTALL=1
             INSTALL_ENABLED=1
@@ -190,7 +190,7 @@ fi
 }
 
 # fail early if the AFH file format is incorrect and/or the file does not exist.
-[[ -n "$AHF_LOCATION" ]] && {
+[[ -n "$AHF_LOCATION" ]] || [[ $AHF_INSTALL -eq 1 ]] && {
 
     [[ ! "$AHF_LOCATION" =~ $AHF_LOCATION_PARAM ]] && {
         echo "Incorrect parameter provided for AHF_LOCATION: $AHF_LOCATION"

Diff for: check-oracle.yml

@@ -15,7 +15,7 @@
 # check-oracle.yml
 - name: "ORAchk: uninstall, install or run"
   hosts: all
-  become: true
+  become: false
   gather_facts: false
   roles:
     - role: check-oracle
@@ -28,6 +28,7 @@
       register: ahfctl_script
 
     - name: Uninstall AHF
+      become: true
       shell: yes 'Y' | "{{ AHFCTL_PATH }}" uninstall
       when: (uninstall_ahf | bool) and ahfctl_script.stat.exists
       ignore_errors: true
@@ -52,65 +53,82 @@
             local_ahf_path: "/tmp/{{ AHF_LOCATION | basename }}"
           block:
 
+            # leave these here for testing
+            # this has been a problem area
+            #- name: Local AHF File
+              #debug:
+                #msg: "AHF File Source: {{ local_ahf_path }}"
+
+            #- name: Remote AHF File Dest
+              #debug:
+                #msg: "AHF File Dest: {{ ahf_extract_path }}/{{ AHF_LOCATION | basename }}"
+
             - name: Download AHF file from Google Storage to the ansible control node.
               local_action: 
                 module: command
                 cmd: "gsutil cp {{ AHF_LOCATION }} {{ local_ahf_path }}"
               register: gsutil_result
               changed_when: gsutil_result.rc == 0
 
-            - name: Check if {{ local_ahf_path }} is a zip file
-              local_action:
-                module: command
-                cmd: unzip -l "{{ local_ahf_path }}"
-              register: zip_check
-              until: zip_check.rc == 0 
-              retries: 3 # Adjust the number of retries
-              delay: 1 # Delay between retries
-              failed_when: zip_check.rc != 0
-              ignore_errors: true
+            - name: Check if {{ local_ahf_path }} exists
+              stat:
+                path: "{{ local_ahf_path }}"
+              register: file_status_check
+              delegate_to: localhost
+
+            - name: File Status
+              debug:
+                msg: "file exists"
+              when: file_status_check.stat.exists
+
+            - name: Fail if the file does not exist
+              fail:
+                msg: "File {{ local_ahf_path }} does not exist."
+              when: not file_status_check.stat.exists
 
             - name: Copy AHF file to remote host if it is a zip file.
+              become: true
               copy:
                 src: "{{ local_ahf_path }}"
                 dest: "{{ ahf_extract_path }}/{{ AHF_LOCATION | basename }}"
-              when: zip_check.rc == 0
+              when: file_status_check.stat.exists == 0
 
             - name: remove local AHF file.
               file:
                 path: "{{ local_ahf_path }}"
                 state: absent
-
-          rescue:
-            - name: remove local AHF file on failure.
-              file:
-                path: "{{ local_ahf_path }}"
-                state: absent
+              delegate_to: localhost
 
         - name: Unzip AHF file
+          become: true
           unarchive:
             src: "{{ ahf_extract_path }}/{{ AHF_LOCATION | basename }}"
             dest: "{{ ahf_extract_path }}"
             remote_src: true
 
         - name: Verify AHF setup signature
+          become: true
           shell: openssl dgst -sha256 -verify ./oracle-tfa.pub -signature ./ahf_setup.dat ./ahf_setup
           args:
             chdir: "{{ ahf_extract_path }}"
 
         - name: Ensure perl is installed
+          become: true
           package:
             name: perl
             state: present
 
         - name: Run AHF setup
+          become: true
           shell: yes 'Y' | ./ahf_setup -extract -notfasetup
           args:
             chdir: "{{ ahf_extract_path }}"
       when: ( not ( uninstall_ahf | bool ) ) and ( not ( run_orachk | bool ) )
 
     - block:
+
         - name: Copy login.sql file to target system
+          become: true
           copy:
             src: roles/check-oracle/files/login.sql
             dest: "{{ orachk_script_dir }}/login.sql"
@@ -119,6 +137,7 @@
             mode: '0600'
 
         - name: Copy orachk-quicktest.sh for expedited testing
+          become: true
           copy:
             src: roles/check-oracle/files/orachk-quicktest.sh
             dest: "{{ ORACHK_BASE }}/orachk/orachk-quicktest.sh"
@@ -128,6 +147,7 @@
           when: ( expedited_testing | bool )
 
         - name: Configure Expedited Testing
+          become: true
           shell:  cd  "{{ ORACHK_BASE }}/orachk/" && [[ ! -r orachk.orig ]] && mv orachk orachk.orig && ln -s orachk-quicktest.sh orachk
           when: ( expedited_testing | bool )
 
@@ -182,6 +202,7 @@
             TMPFILE: "{{ lookup('pipe','mktemp') }}"
 
         - name: Run ORAchk
+          become: true
           shell: "ORACLE_PATH={{ orachk_script_dir }} SQLPATH={{ orachk_script_dir }} {{ ORACHK_BASE }}/orachk/orachk -s -dbconfig {{ ORACLE_HOME }}%{{ ORACLE_SID }} -showpass -profile dba | tee {{ TMPFILE }}"
           environment:
             ORACLE_SID: "{{ ORACLE_SID }}"
@@ -225,6 +246,7 @@
           register: fetch_result
 
         - name: Deconfigure Expedited Testing
+          become: true
           shell:  cd  "{{ ORACHK_BASE }}/orachk/" && [[ -r orachk.orig ]] && rm -f orachk && mv orachk.orig orachk && rm -f orachk-quicktest.sh
           when: ( expedited_testing | bool )