Skip to content

Commit 9bf2628

Browse files
Enable adding new database to an existing VM where the install_oracle.sh script was previosly run. (#63)
* Add the add_database functionality * Add the add_database functionality * Fixed the undefined oracle-home var error * Fxing more issues with undefined vars * Fxing more issues with undefined vars * Fxing more issues with undefined vars * Fixed the add_database.sh skipping db creation * Fixed misc. issues with the db crreation and handling the listener * Fixed misc. issues with the db crreation and handling the listener * Fixed misc. issues with the db crreation and handling the listener * Fixed misc. issues with the db crreation and handling the listener * Fixing issue with missing sw location * Another attempt to fix listener issues * 1. Issues are caught as early as possible 2. Error messages are clear and explain why the operation can't proceed 3. Users understand the resource requirements before starting the time-consuming DB creation process * 1. Adding an explicit conversion step that converts the string values to floating-point numbers using the float filter in Ansible 2. Creating new variables for the floating-point values: sga_size_gb_float and pga_size_gb_float 3. Using these floating-point variables in the calculation * Fixing issues with memory check * Fixing issues with memory checks * Improve memory calculation precision in db-create role - Change memory check command from 'free -g' to 'free -m' for more precise measurements - Convert memory values to GB with decimal precision using division and rounding - Minor formatting adjustment to commented verbosity line * Fixing memory check * Fixing memory check * Fixing memory check * Fixing memory check * Fixing memory check * Fixing memory check * Fixing memory check * Fixing backup script generation code * Remove default swlib_unzip_path fallback in config-db.yml * Configure Oracle control file autobackup format for RECO disk group * Update Oracle home detection to use 'oracle' binary instead of 'sqlplus' * Fixing backup config issue * Fixing how we handle the + prefix in the --ora-reco-destination * Refactored the oracle home validaiton logic to be in a different file * Code dediplication * Improved docs for adding a new db * Changed the multiline shell command to a single line as requested. * Updated the documentation to reflect that we check for the 'oracle' binary instead of 'sqlplus'. * Docs improvments and code cleanup/deduplication * 1. Removed the redundant default setting for swlib_unzip_path in roles/db-create/tasks/main.yml and replaced it with a comment explaining that it's already defined in group_vars/all.yml. 2. Removed all inline default fallbacks (swlib_unzip_path | default('/tmp/oracle_swlib')) in the following places: - The template destination path for the register_db_listener.sh.j2 template - The shell command that executes the register_db script - The file path when removing the registration script * Improved the way we look for the oracle home * Improved the way we look for the oracle home * Made the parameter for setting Oracle Home mandatory and only way to determine the Oracle home * Fixing handling of the input parameter backup_dest properly * Be optional for the install-oracle.sh script, using a best-practice default path when not provided: : * Be optional for the install-oracle.sh script, using a best-practice default path when not provided: : * explicitly converts memory_pct to an integer using the | int filter in two places * The fix adds explicit integer conversion to both ansible_memory_mb.real.total and memory_pct variables before performing the calculation. This ensures that both values are integers before the floor division operation (//), preventing the error where Ansible was attempting to use floor division between a string and an integer.
1 parent 616548a commit 9bf2628

File tree

17 files changed

+2266
-32
lines changed

17 files changed

+2266
-32
lines changed

.ansible/.lock

Whitespace-only changes.

.cursor/rules/coding-rules.mdc

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
---
2+
description:
3+
globs:
4+
alwaysApply: true
5+
---
6+
- Make sure you write clean, concise and efficient ansible code. It should not just work, it shoudl be properly written.
7+
- We are running this on my local machine, but it will be executed on a remote VM inthe Google CLoud, so do not execute things here.
8+
- Make sure not to duplicate code.
9+
- Do not change the fremaeworks or approach to solving issues dramatcially.

0 commit comments

Comments
 (0)