Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task generateProto is not executed during build in version 0.9.3 #701

Closed
TorbenSp09 opened this issue May 9, 2023 · 2 comments
Closed

Comments

@TorbenSp09
Copy link

TorbenSp09 commented May 9, 2023

Hey, i have a gradle-project using JDK v16.0.1. I just wanted to update the version of the protobuf plugin from v0.8.18 to v0.9.3. Added to that, i am using v3.22.2 of the protobuf compiler.
I have two .proto files that i need in my project. Since i updated from v0.8.18 -> v0.9.3 the generateProto task won't be executed during build. This causes some errors in my CI/CD pipeline and i don't know why this happens. These were the steps executed using v0.8.18:
image

However, these are the steps executed after updating to v0.9.3:
image

As shown, the kotlinCompiler fails because the dependencies that are created by generateProto are missing now.
I have already tried several things, including manually setting the source set of the .proto files, but nothing has worked. I have also taken a look into the release notes but there i can't see anything that will cause this. I know that it is possible to add the generateProto task to the build task but i think this is not the right way to go is it?

Thank you!

@ejona86
Copy link
Collaborator

ejona86 commented May 9, 2023

The protobuf compiler version probably doesn't matter.

"Added generated code to java SourceSet" and "Substantial internal modernization" from 0.9.0 are the parts from the release notes probably related to this. Previously the plugin had explicit code for Kotlin that modified the compileKotlin task. Now the sources are added to the sourceSet and picked up automatically.

We have tests for Kotlin code, and other Kotlin users seem to have been working, so the question is "what is special about your build?" A reproduction is most helpful. Without even build snippets, there's nothing for us to go on.

@ejona86
Copy link
Collaborator

ejona86 commented Jun 28, 2023

No response to provide more information, so closing. More information can be provided and then we can reopen.

@ejona86 ejona86 closed this as completed Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants