Can we start making each file's code cleaner?

[MattMarquise]

Many of the files in this repo contain somewhat unclean code. Can we make it a priority to simply use very common nesting rules to eventually make all the files' code clean.

[omkar342]

Can I solve this issue ?

[MattMarquise]

@omkar342 I've started working on a few files already and there's a lot to cover. But the code simply isn't nested properly and makes it a bit headachy when adding to. So yes absolutely!

[MattMarquise]

However for some reason the PRs I made haven't been accepted yet. Obviously no one if checking the PRs for this repo

[tonyruscoe]

Hi there.

Thanks for sharing your thoughts here!

Most of the files in this repo are generated from style guides we maintain internally, often in other formats, so the markup is often being automatically generated. If we accept pull requests to update the formatting, those changes would likely just get overwritten and reverted whenever the next update is made.

To fix this issue, we’d really need to update our workflows to re-format the generated markup before it gets committed here. I’ll take a look at the scripts which generate these files and see whether there’s an easy way to improve the format of the generated output.

Tony

[MattMarquise]

@tonyruscoe Thanks! I'd love to help contribute to this repo but if everything just gets overwritten then please let me know what I can do.

[vapier]

feel free to ask about specific files and we can tell you what's generated/how, and what isn't

most of the "guide" files are generated, so trying to fix their internal style doesn't make sense. just read them online and focus on their content.