JSX: Fix whitespace and escaping of attribute values

The behavior is reversed engineer from Babel since the
semantics is not documented in the JSX "spec".

Fixes #2088

Author: arv

src/codegeneration/JsxTransformer.js

@@ -17,13 +17,15 @@ import {
   JSX_PLACEHOLDER,
   JSX_SPREAD_ATTRIBUTE,
   JSX_TEXT,
+  LITERAL_EXPRESSION,
 } from '../syntax/trees/ParseTreeType.js';
 import {
   JsxText,
   LiteralExpression,
   LiteralPropertyName,
   SpreadExpression,
 } from '../syntax/trees/ParseTrees.js';
+import {LiteralToken} from '../syntax/LiteralToken.js';
 import {ParseTreeTransformer} from './ParseTreeTransformer.js';
 import {STRING} from '../syntax/TokenType.js';
 import {
@@ -135,6 +137,13 @@ export class JsxTransformer extends ParseTreeTransformer {
     let value;
     if (tree.value === null) {
       value = createTrueLiteral();
+    } else if (tree.value.type === LITERAL_EXPRESSION) {
+      const {literalToken} = tree.value;
+      const v = literalToken.value;
+      const {location} = literalToken;
+      const lit =
+          new LiteralToken(STRING, normalizeAttributeValue(v), location);
+      value = new LiteralExpression(location, lit);
     } else {
       value = this.transformAny(tree.value);
     }
@@ -202,3 +211,9 @@ function jsxIdentifierToToken(token) {
   }
   return createIdentifierToken(value);
 }
+
+function normalizeAttributeValue(s) {
+  return JSON.stringify(
+      s.slice(1, -1).  // remove the quotes
+      replace(/\n\s+/g, ' '));
+}

test/feature/JSX/AttributesWhitespace.js

@@ -0,0 +1,30 @@
+// Options: --jsx=f
+
+// This file has trailing whitespace. Make sure your editor does not strip
+// them.
+
+function f(name, props) {
+  return props.b;
+}
+
+assert.equal(<a b=" c "/>, ' c ');
+assert.equal(<a b="  c  "/>, '  c  ');
+assert.equal(<a b="c "/>, 'c ');
+assert.equal(<a b="c "/>, 'c ');
+assert.equal(<a b="\tc\n"/>, '\\tc\\n');
+assert.equal(<a b="'"/>, '\'');
+assert.equal(<a b='"'/>, '"');
+assert.equal(<a b="&"/>, '&');
+assert.equal(<a b='
+'/>, '\n');
+assert.equal(<a b=' 
+'/>, ' \n');
+assert.equal(<a b='
+ '/>, ' ');
+assert.equal(<a b='
+
+'/>, ' ');
+assert.equal(<a b=' 
+
+'/>, '  ');
+assert.equal(<a b='	'/>, '\t');