Skip to content

Commit 7d3e6e4

Browse files
authored
test: fixes gapic spanner test (#904)
We were not closing the spanner service instance after using it, causing threads not to be terminated. Here we make sure to close such service in a try with resources block.
1 parent 7f4ccf2 commit 7d3e6e4

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

google-cloud-spanner/src/test/java/com/google/cloud/spanner/spi/v1/GapicSpannerRpcTest.java

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -511,16 +511,17 @@ public void testAdminRequestsLimitExceededRetryAlgorithm() {
511511
@Test
512512
public void testDefaultUserAgent() {
513513
final SpannerOptions options = createSpannerOptions();
514-
final Spanner spanner = options.getService();
515-
final DatabaseClient databaseClient =
516-
spanner.getDatabaseClient(DatabaseId.of("[PROJECT]", "[INSTANCE]", "[DATABASE]"));
514+
try (final Spanner spanner = options.getService()) {
515+
final DatabaseClient databaseClient =
516+
spanner.getDatabaseClient(DatabaseId.of("[PROJECT]", "[INSTANCE]", "[DATABASE]"));
517517

518-
try (final ResultSet rs = databaseClient.singleUse().executeQuery(SELECT1AND2)) {
519-
rs.next();
520-
}
518+
try (final ResultSet rs = databaseClient.singleUse().executeQuery(SELECT1AND2)) {
519+
rs.next();
520+
}
521521

522-
assertThat(seenHeaders.get(Key.of("user-agent", Metadata.ASCII_STRING_MARSHALLER)))
523-
.contains(defaultUserAgent);
522+
assertThat(seenHeaders.get(Key.of("user-agent", Metadata.ASCII_STRING_MARSHALLER)))
523+
.contains(defaultUserAgent);
524+
}
524525
}
525526

526527
@Test

0 commit comments

Comments
 (0)