Commit 92494d0
authored
chore: util method for creating statement with params (#3817)
Currently, statements with parameters can only be created through a Statement.Builder.
This has the disadvantage that Statement.Builder uses a StringBuilder internally, which
means that each time Statement.newBuilder() is called, a new StringBuilder with the initial
SQL statement is created. Later, when the statement is built, the contents of the StringBuilder
are copied into a new string. This is efficient for statements that are built with multiple
SQL fragements that are appended together. It is however inefficient for statements that are
created with a fixed SQL string.
This change therefore adds an additional util method to directly create a Statement from a
string and an immutable map of parameters. Calling this method directly does not invoke any
internal copy methods, and is more efficient for clients that have both the SQL string and
the parameters readily available. This method will be used by PGAdapter, that does have this
information available directly.1 parent b6c9c6e commit 92494d0
File tree
2 files changed
+18
-0
lines changed- google-cloud-spanner/src
- main/java/com/google/cloud/spanner
- test/java/com/google/cloud/spanner
2 files changed
+18
-0
lines changedLines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
144 | 144 | | |
145 | 145 | | |
146 | 146 | | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
147 | 152 | | |
148 | 153 | | |
149 | 154 | | |
| |||
Lines changed: 13 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
| 22 | + | |
21 | 23 | | |
22 | 24 | | |
23 | 25 | | |
| |||
42 | 44 | | |
43 | 45 | | |
44 | 46 | | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
45 | 58 | | |
46 | 59 | | |
47 | 60 | | |
| |||
0 commit comments