adds debugging to noxfile and tweaks to correct coverage

Author: chalmerlowe

noxfile.py

@@ -18,10 +18,12 @@
 
 from __future__ import absolute_import
 
+from functools import wraps
 import os
 import pathlib
 import re
 import shutil
+import time
 from typing import Dict, List
 import warnings
 
@@ -100,6 +102,27 @@
 
 CURRENT_DIRECTORY = pathlib.Path(__file__).parent.absolute()
 
+
+def _calculate_duration(func):
+    """This decorator prints the execution time for the decorated function."""
+
+    @wraps(func)
+    def wrapper(*args, **kwargs):
+        start = time.monotonic()
+        result = func(*args, **kwargs)
+        end = time.monotonic()
+        total_seconds = round(end - start)
+        hours = total_seconds // 3600  # Integer division to get hours
+        remaining_seconds = total_seconds % 3600  # Modulo to find remaining seconds
+        minutes = remaining_seconds // 60
+        seconds = remaining_seconds % 60
+        human_time = f"{hours:}:{minutes:0>2}:{seconds:0>2}"
+        print(f"Session ran in {total_seconds} seconds ({human_time})")
+        return result
+
+    return wrapper
+
+
 nox.options.sessions = [
     "unit",
     "system",
@@ -118,13 +141,15 @@
 
 
 @nox.session(python=DEFAULT_PYTHON_VERSION)
+@_calculate_duration
 def lint(session):
     """Run linters.
 
     Returns a failure if the linters find linting errors or sufficiently
     serious code quality issues.
     """
     session.install(FLAKE8_VERSION, BLACK_VERSION)
+    session.run("python", "-m", "pip", "freeze")
     session.run(
         "black",
         "--check",
@@ -134,16 +159,19 @@ def lint(session):
 
 
 @nox.session(python=DEFAULT_PYTHON_VERSION)
+@_calculate_duration
 def blacken(session):
     """Run black. Format code to uniform standard."""
     session.install(BLACK_VERSION)
+    session.run("python", "-m", "pip", "freeze")
     session.run(
         "black",
         *LINT_PATHS,
     )
 
 
 @nox.session(python=DEFAULT_PYTHON_VERSION)
+@_calculate_duration
 def format(session):
     """
     Run isort to sort imports. Then run black
@@ -152,6 +180,7 @@ def format(session):
     session.install(BLACK_VERSION, ISORT_VERSION)
     # Use the --fss option to sort imports using strict alphabetical order.
     # See https://pycqa.github.io/isort/docs/configuration/options.html#force-sort-within-sections
+    session.run("python", "-m", "pip", "freeze")
     session.run(
         "isort",
         "--fss",
@@ -164,9 +193,11 @@ def format(session):
 
 
 @nox.session(python=DEFAULT_PYTHON_VERSION)
+@_calculate_duration
 def lint_setup_py(session):
     """Verify that setup.py is valid (including RST check)."""
     session.install("docutils", "pygments")
+    session.run("python", "-m", "pip", "freeze")
     session.run("python", "setup.py", "check", "--restructuredtext", "--strict")
 
 
@@ -203,6 +234,7 @@ def install_unittest_dependencies(session, *constraints):
     "protobuf_implementation",
     ["python", "upb", "cpp"],
 )
+@_calculate_duration
 def unit(session, protobuf_implementation, install_extras=True):
     # Install all test dependencies, then install this package in-place.
 
@@ -229,6 +261,7 @@ def unit(session, protobuf_implementation, install_extras=True):
         session.install("protobuf<4")
 
     # Run py.test against the unit tests.
+    session.run("python", "-m", "pip", "freeze")
     session.run(
         "py.test",
         "--quiet",
@@ -278,6 +311,7 @@ def install_systemtest_dependencies(session, *constraints):
 
 
 @nox.session(python=SYSTEM_TEST_PYTHON_VERSIONS)
+@_calculate_duration
 def system(session):
     """Run the system test suite."""
     constraints_path = str(
@@ -300,6 +334,7 @@ def system(session):
         session.skip("System tests were not found")
 
     install_systemtest_dependencies(session, "-c", constraints_path)
+    session.run("python", "-m", "pip", "freeze")
 
     # Run py.test against the system tests.
     if system_test_exists:
@@ -321,6 +356,7 @@ def system(session):
 
 
 @nox.session(python=SYSTEM_TEST_PYTHON_VERSIONS)
+@_calculate_duration
 def system_noextras(session):
     """Run the system test suite."""
     constraints_path = str(
@@ -345,6 +381,7 @@ def system_noextras(session):
     global SYSTEM_TEST_EXTRAS_BY_PYTHON
     SYSTEM_TEST_EXTRAS_BY_PYTHON = False
     install_systemtest_dependencies(session, "-c", constraints_path)
+    session.run("python", "-m", "pip", "freeze")
 
     # Run py.test against the system tests.
     if system_test_exists:
@@ -366,6 +403,7 @@ def system_noextras(session):
 
 
 @nox.session(python=SYSTEM_TEST_PYTHON_VERSIONS[-1])
+@_calculate_duration
 def compliance(session):
     """Run the SQLAlchemy dialect-compliance system tests"""
     constraints_path = str(
@@ -418,19 +456,22 @@ def compliance(session):
 
 
 @nox.session(python=DEFAULT_PYTHON_VERSION)
+@_calculate_duration
 def cover(session):
     """Run the final coverage report.
 
     This outputs the coverage report aggregating coverage from the unit
     test runs (not system test runs), and then erases coverage data.
     """
     session.install("coverage", "pytest-cov")
+    session.run("python", "-m", "pip", "freeze")
     session.run("coverage", "report", "--show-missing", "--fail-under=100")
 
     session.run("coverage", "erase")
 
 
 @nox.session(python="3.10")
+@_calculate_duration
 def docs(session):
     """Build the docs for this library."""
 
@@ -453,6 +494,7 @@ def docs(session):
     )
 
     shutil.rmtree(os.path.join("docs", "_build"), ignore_errors=True)
+    session.run("python", "-m", "pip", "freeze")
     session.run(
         "sphinx-build",
         "-W",  # warnings as errors
@@ -468,6 +510,7 @@ def docs(session):
 
 
 @nox.session(python="3.10")
+@_calculate_duration
 def docfx(session):
     """Build the docfx yaml files for this library."""
 
@@ -490,6 +533,7 @@ def docfx(session):
     )
 
     shutil.rmtree(os.path.join("docs", "_build"), ignore_errors=True)
+    session.run("python", "-m", "pip", "freeze")
     session.run(
         "sphinx-build",
         "-T",  # show full traceback on exception
@@ -520,6 +564,7 @@ def docfx(session):
     "protobuf_implementation",
     ["python", "upb", "cpp"],
 )
+@_calculate_duration
 def prerelease_deps(session, protobuf_implementation):
     """Run all tests with prerelease versions of dependencies installed."""
 
@@ -581,6 +626,7 @@ def prerelease_deps(session, protobuf_implementation):
         "requests",
     ]
     session.install(*other_deps)
+    session.run("python", "-m", "pip", "freeze")
 
     # Print out prerelease package versions
     session.run(

setup.py

@@ -62,7 +62,7 @@ def readme():
         # https://github.com/grpc/grpc/pull/15254
         "grpcio >= 1.47.0, < 2.0.0",
         "grpcio >= 1.49.1, < 2.0.0; python_version>='3.11'",
-        "pyarrow >= 3.0.0",
+        "pyarrow >= 5.0.0",
     ],
 }
 

sqlalchemy_bigquery/__init__.py

@@ -48,14 +48,16 @@
 from . import _versions_helpers
 
 sys_major, sys_minor, sys_micro = _versions_helpers.extract_runtime_version()
-if sys_major == 3 and sys_minor in (7, 8):
+# Now that support for Python 3.7 and 3.8 has been removed, we don't expect the
+# following check to succeed. The warning is only included for robustness.
+if sys_major == 3 and sys_minor in (7, 8):  # pragma: NO COVER
     warnings.warn(
-        "The python-bigquery library will stop supporting Python 3.7 "
-        "and Python 3.8 in a future major release expected in Q4 2024. "
+        "The python-bigquery-sqlalchemy library no longer supports Python 3.7 "
+        "and Python 3.8. "
         f"Your Python version is {sys_major}.{sys_minor}.{sys_micro}. We "
         "recommend that you update soon to ensure ongoing support. For "
         "more details, see: [Google Cloud Client Libraries Supported Python Versions policy](https://cloud.google.com/python/docs/supported-python-versions)",
-        PendingDeprecationWarning,
+        FutureWarning,
     )
 
 

testing/constraints-3.9.txt

@@ -0,0 +1,14 @@
+# This constraints file is used to check that lower bounds
+# are correct in setup.py
+# List *all* library dependencies and extras in this file.
+# Pin the version to the lower bound.
+#
+# e.g., if setup.py has "foo >= 1.14.0, < 2.0.0dev",
+sqlalchemy==1.4.16
+google-auth==1.25.0
+google-cloud-bigquery==3.3.6
+google-cloud-bigquery-storage==2.0.0
+google-api-core==1.31.5
+grpcio==1.47.0
+numpy==1.26.4
+pyarrow==5.0.0