feat: support ruby 3.4 (#359)

* feat: ruby 3.1

* Force CI re-evaluation

* more details

* more details

* less details

* more details

* add exclusion to nightly unit tests

Author: viacheslav-rostovtsev

.github/workflows/acceptance-tests-on-emulator.yaml

@@ -18,12 +18,18 @@ jobs:
     strategy:
       max-parallel: 4
       matrix:
-        ruby: ["3.1", "3.2", "3.3"]
+        ruby: ["3.1", "3.2", "3.3", "3.4"]
         ar: ["~> 7.0.0", "~> 7.1.0", "~> 7.2.0", "~> 8.0.0"]
         # Exclude combinations that are not supported.
         exclude:
           - ruby: "3.1"
             ar: "~> 8.0.0"
+          - ruby: "3.4"
+            ar: "~> 7.0.0"
+          - ruby: "3.4"
+            ar: "~> 7.1.0"
+          - ruby: "3.4"
+            ar: "~> 7.2.0"
     env:
       AR_VERSION: ${{ matrix.ar }}
     steps:

.github/workflows/ci.yaml

@@ -10,12 +10,18 @@ jobs:
     strategy:
       max-parallel: 4
       matrix:
-        ruby: ["3.1", "3.2", "3.3"]
+        ruby: ["3.1", "3.2", "3.3", "3.4"]
         ar: ["~> 7.0.0", "~> 7.1.0", "~> 7.2.0", "~> 8.0.0"]
         # Exclude combinations that are not supported.
         exclude:
           - ruby: "3.1"
             ar: "~> 8.0.0"
+          - ruby: "3.4"
+            ar: "~> 7.0.0"
+          - ruby: "3.4"
+            ar: "~> 7.1.0"
+          - ruby: "3.4"
+            ar: "~> 7.2.0"
     env:
       AR_VERSION: ${{ matrix.ar }}
     steps:
@@ -30,4 +36,4 @@ jobs:
     - name: Install dependencies
       run: bundle install
     - name: Run tests
-      run: bundle exec rake test TESTOPTS="-v"
+      run: bundle exec rake test --trace TESTOPTS="-v"

.github/workflows/nightly-acceptance-tests-on-emulator.yaml

@@ -18,12 +18,18 @@ jobs:
     strategy:
       max-parallel: 4
       matrix:
-        ruby: ["3.1", "3.2", "3.3"]
+        ruby: ["3.1", "3.2", "3.3", "3.4"]
         ar: ["~> 7.0.0", "~> 7.1.0", "~> 7.2.0", "~> 8.0.0"]
         # Exclude combinations that are not supported.
         exclude:
           - ruby: "3.1"
             ar: "~> 8.0.0"
+          - ruby: "3.4"
+            ar: "~> 7.0.0"
+          - ruby: "3.4"
+            ar: "~> 7.1.0"
+          - ruby: "3.4"
+            ar: "~> 7.2.0"
     env:
       AR_VERSION: ${{ matrix.ar }}
     steps:

.github/workflows/nightly-unit-tests.yaml

@@ -11,12 +11,18 @@ jobs:
       max-parallel: 4
       matrix:
         # Run acceptance tests all supported combinations of Ruby and ActiveRecord.
-        ruby: ["3.1", "3.2", "3.3"]
+        ruby: ["3.1", "3.2", "3.3", "3.4"]
         ar: ["~> 7.0.0", "~> 7.1.0", "~> 7.2.0", "~> 8.0.0"]
         # Exclude combinations that are not supported.
         exclude:
           - ruby: "3.1"
             ar: "~> 8.0.0"
+          - ruby: "3.4"
+            ar: "~> 7.0.0"
+          - ruby: "3.4"
+            ar: "~> 7.1.0"
+          - ruby: "3.4"
+            ar: "~> 7.2.0"
     env:
       AR_VERSION: ${{ matrix.ar }}
     steps:

.github/workflows/samples.yaml

@@ -8,12 +8,18 @@ jobs:
     strategy:
       max-parallel: 4
       matrix:
-        ruby: ["3.1", "3.2", "3.3"]
+        ruby: ["3.1", "3.2", "3.3", "3.4"]
         ar: ["~> 7.0.0", "~> 7.1.0", "~> 7.2.0", "~> 8.0.0"]
         # Exclude combinations that are not supported.
         exclude:
           - ruby: "3.1"
             ar: "~> 8.0.0"
+          - ruby: "3.4"
+            ar: "~> 7.0.0"
+          - ruby: "3.4"
+            ar: "~> 7.1.0"
+          - ruby: "3.4"
+            ar: "~> 7.2.0"
     env:
       AR_VERSION: ${{ matrix.ar }}
     steps:

activerecord-spanner-adapter.gemspec

@@ -30,7 +30,7 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "autotest-suffix", "~> 1.1"
   spec.add_development_dependency "bundler", "~> 2.0"
-  spec.add_development_dependency "google-style", "~> 1.30.1"
+  spec.add_development_dependency "google-style", "~> 1.31.0"
   spec.add_development_dependency "minitest", "~> 5.10"
   spec.add_development_dependency "minitest-autotest", "~> 1.0"
   spec.add_development_dependency "minitest-focus", "~> 1.1"

lib/active_record/connection_adapters/spanner/database_statements.rb

@@ -29,7 +29,7 @@ def internal_exec_query sql, name = "SQL", binds = [], prepare: false, async: fa
         end
 
         def internal_execute sql, name = "SQL", binds = [],
-                             prepare: false, async: false, allow_retry: false # rubocop:disable Lint/UnusedMethodArgument, /
+                             prepare: false, async: false, allow_retry: false # rubocop:disable Lint/UnusedMethodArgument
           statement_type = sql_statement_type sql
           # Call `transform` to invoke any query transformers that might have been registered.
           sql = transform sql
@@ -406,8 +406,10 @@ def create_delete_all_mutation arel
         end
 
         DDL_REGX = build_sql_statement_regexp(:create, :alter, :drop).freeze
+        private_constant :DDL_REGX
 
         DML_REGX = build_sql_statement_regexp(:insert, :delete, :update).freeze
+        private_constant :DML_REGX
 
         def sql_statement_type sql
           case sql

lib/activerecord_spanner_adapter/base.rb

@@ -21,7 +21,7 @@ class Base
     # Creates an object (or multiple objects) and saves it to the database. This method will use mutations instead
     # of DML if there is no active transaction, or if the active transaction has been created with the option
     # isolation: :buffered_mutations.
-    def self.create! attributes = nil, &block
+    def self.create!(attributes = nil, &)
       return super unless spanner_adapter?
       return super if active_transaction?
 
@@ -30,7 +30,7 @@ def self.create! attributes = nil, &block
       end
     end
 
-    def self.create attributes = nil, &block
+    def self.create(attributes = nil, &)
       return super unless spanner_adapter?
       return super if active_transaction?