Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to delete all tickets in OM #152

Closed
wants to merge 2 commits into from
Closed

Conversation

yfei1
Copy link
Collaborator

@yfei1 yfei1 commented Mar 12, 2020

Resolved open-match#1136

image

site/content/en/docs/FAQ/delete_all.md Outdated Show resolved Hide resolved
site/content/en/docs/FAQ/delete_all.md Show resolved Hide resolved
}
}
}
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this handle pending tickets or tickets that are already assigned?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what is the agreement on #1136? I thought this doc was intended to document how to delete all tickets in OM?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More than the documentation itself, I am concerned about the implementation for:
googleforgames/open-match#1151

Looks like that goes through query service - so I assume you will only get Active IDs? So is this statement on that API proto accurate:
If the Pool contains no Filters, QueryTicketIds will return all TicketIDs in the state storage. ?

The primary user scenario here was to have an ability to cleanup Open Match state storage - and if there is a simpler way to do that, we should consider that. Providing a state specific API may be cleaner (get all pending / get all assigned / get all in all states) but thats a lower priority.

Also, we dont expect this to be called at scale - so going through query cache for this is not a requirement.

@yfei1
Copy link
Collaborator Author

yfei1 commented Mar 20, 2020

Closing this as we gonna move this issue to v1.0

@yfei1 yfei1 closed this Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to delete all tickets in Open Match
3 participants