Skip to content

Commit 388a323

Browse files
committed
require at least Go >= 1.13 because gomacro no longer compiles on Go < 1.13
1 parent bd558dd commit 388a323

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

.travis.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
language: go
22

33
go:
4+
- 1.15.x
45
- 1.14.x
56
- 1.13.x
6-
- 1.12.x
77
- master
88

99
matrix:

README.md

+6-6
Original file line numberDiff line numberDiff line change
@@ -41,15 +41,15 @@
4141

4242
### Prerequisites
4343

44-
- [Go 1.11+](https://golang.org/doc/install) - including GOPATH/bin added to your PATH (i.e., you can run Go binaries that you `go install`).
44+
- [Go 1.13+](https://golang.org/doc/install) - including GOPATH/bin added to your PATH (i.e., you can run Go binaries that you `go install`).
4545
- [Jupyter Notebook](http://jupyter.readthedocs.io/en/latest/install.html) or [nteract](https://nteract.io/desktop)
4646
- [git](https://git-scm.com/download) - usually already present on Linux and Mac OS X. If not present, follow the instructions at [https://git-scm.com/download](https://git-scm.com/download)
4747

4848
### Linux or FreeBSD
4949

5050
The instructions below should work both on Linux and on FreeBSD.
5151

52-
Quick installation as module, requires Go 1.12+
52+
Method 1: quick installation as module
5353
```sh
5454
$ env GO111MODULE=on go get github.com/gopherdata/gophernotes
5555
$ mkdir -p ~/.local/share/jupyter/kernels/gophernotes
@@ -59,7 +59,7 @@ $ chmod +w ./kernel.json # in case copied kernel.json has no write permission
5959
$ sed "s|gophernotes|$(go env GOPATH)/bin/gophernotes|" < kernel.json.in > kernel.json
6060
```
6161

62-
Manual installation from GOPATH, also works with Go 1.11
62+
Method 2: manual installation from GOPATH
6363
```sh
6464
$ env GO111MODULE=off go get -d -u github.com/gopherdata/gophernotes
6565
$ cd "$(go env GOPATH)"/src/github.com/gopherdata/gophernotes
@@ -90,7 +90,7 @@ $ jupyter --data-dir
9090

9191
**Important Note** - gomacro relies on the `plugin` package when importing third party libraries. This package works reliably on Mac OS X with Go 1.10.2+ as long as you **never** execute the command `strip gophernotes`.
9292

93-
Quick installation as module, requires Go 1.12+
93+
Method 1: quick installation as module
9494
```sh
9595
$ env GO111MODULE=on go get github.com/gopherdata/gophernotes
9696
$ mkdir -p ~/Library/Jupyter/kernels/gophernotes
@@ -100,7 +100,7 @@ $ chmod +w ./kernel.json # in case copied kernel.json has no write permission
100100
$ sed "s|gophernotes|$(go env GOPATH)/bin/gophernotes|" < kernel.json.in > kernel.json
101101
```
102102

103-
Manual installation from GOPATH, also works with Go 1.11
103+
Method 2: manual installation from GOPATH
104104
```sh
105105
$ env GO111MODULE=off go get -d -u github.com/gopherdata/gophernotes
106106
$ cd "$(go env GOPATH)"/src/github.com/gopherdata/gophernotes
@@ -244,7 +244,7 @@ Restart jupyter, and you should now be up and running.
244244
245245
### error "could not import C (no metadata for C)" when importing a package
246246
247-
At a first analysis, it seems to be a limitation of the new import mechanism that supports Go 1.11 modules.
247+
At a first analysis, it seems to be a limitation of the new import mechanism that supports Go modules.
248248
You can switch the old (non module-aware) mechanism with the command `%go111module off`
249249
250250
To re-enable modules support, execute `%go111module on`

go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module github.com/gopherdata/gophernotes
22

3-
go 1.11
3+
go 1.13
44

55
require (
66
github.com/cosmos72/gomacro v0.0.0-20200719111907-b07014b02196

0 commit comments

Comments
 (0)