update Dockerfile* for Go 1.11 modules

Author: cosmos72

Dockerfile

@@ -34,10 +34,12 @@ RUN set -x \
     ### pin down the tornado and ipykernel to compatible versions
     && pip3 install jupyter notebook pyzmq==16.0.2 tornado==4.5.3 ipykernel==4.8.1 \
     ## install gophernotes
-    && GOPATH=/go go install github.com/gopherdata/gophernotes \
+    && cd /go/src/github.com/gopherdata/gophernotes \
+    && GOPATH=/go GO111MODULE=on go install . \
     && cp /go/bin/gophernotes /usr/local/bin/ \
     && mkdir -p ~/.local/share/jupyter/kernels/gophernotes \
-    && cp -r /go/src/github.com/gopherdata/gophernotes/kernel/* ~/.local/share/jupyter/kernels/gophernotes \
+    && cp -r ./kernel/* ~/.local/share/jupyter/kernels/gophernotes \
+    && cd - \
     ## clean
     && find /usr/lib/python3.6 -name __pycache__ | xargs rm -r \
     && rm -rf \
@@ -49,4 +51,4 @@ RUN set -x \
 ENV GOPATH /go
 
 EXPOSE 8888
-CMD [ "jupyter", "notebook", "--no-browser", "--allow-root", "--ip=0.0.0.0" ]
+CMD [ "jupyter", "notebook", "--no-browser", "--allow-root", "--ip=0.0.0.0" ]

Dockerfile.DS

@@ -18,7 +18,7 @@ RUN set -x \
         g++ \
         git \
         py3-zmq \
-        pkgconfig \ 
+        pkgconfig \
         zeromq-dev \
         musl-dev \
         mercurial \
@@ -29,17 +29,20 @@ RUN set -x \
         --repository http://dl-4.alpinelinux.org/alpine/edge/community \
         --arch=x86_64 add \
         go \
-    ## jupyter notebook 
+    ## jupyter notebook
     && ln -s /usr/include/locale.h /usr/include/xlocale.h \
     ### fix pyzmq to v16.0.2 as that is what is distributed with py3-zmq
     ### pin down the tornado and ipykernel to compatible versions
     && pip3 install jupyter notebook pyzmq==16.0.2 tornado==4.5.3 ipykernel==4.8.1 \
     ## install gophernotes
+    && cd /go/src/github.com/gopherdata/gophernotes \
     && export GOPATH=/go \
-    && go install github.com/gopherdata/gophernotes \
+    && export GO111MODULE=on \
+    && go install . \
     && cp /go/bin/gophernotes /usr/local/bin/ \
     && mkdir -p ~/.local/share/jupyter/kernels/gophernotes \
-    && cp -r /go/src/github.com/gopherdata/gophernotes/kernel/* ~/.local/share/jupyter/kernels/gophernotes \
+    && cp -r ./kernel/* ~/.local/share/jupyter/kernels/gophernotes \
+    && cd - \
     ## get the relevant Go packages
     && go get -insecure gonum.org/v1/plot/... \
     && go get -insecure gonum.org/v1/gonum/... \

README.md

@@ -66,7 +66,7 @@ $ env GO111MODULE=on go install
 $ mkdir -p ~/.local/share/jupyter/kernels/gophernotes
 $ cp kernel/* ~/.local/share/jupyter/kernels/gophernotes
 $ cd ~/.local/share/jupyter/kernels/gophernotes
-$ sed "s,gophernotes,$(go env GOPATH)/bin/gophernotes," < kernel.json.in > kernel.json
+$ sed "s|gophernotes|$(go env GOPATH)/bin/gophernotes|" < kernel.json.in > kernel.json
 ```
 
 To confirm that the `gophernotes` binary is installed in GOPATH, execute it directly:
@@ -105,7 +105,7 @@ $ env GO111MODULE=on go install
 $ mkdir -p ~/Library/Jupyter/kernels/gophernotes
 $ cp kernel/* ~/Library/Jupyter/kernels/gophernotes
 $ cd ~/Library/Jupyter/kernels/gophernotes
-$ sed "s,gophernotes,$(go env GOPATH)/bin/gophernotes," < kernel.json.in > kernel.json
+$ sed "s|gophernotes|$(go env GOPATH)/bin/gophernotes|" < kernel.json.in > kernel.json
 ```
 
 To confirm that the `gophernotes` binary is installed in GOPATH, execute it directly: