Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API v2 considerations and requirements #546

Open
gotson opened this issue May 28, 2021 · 2 comments
Open

API v2 considerations and requirements #546

gotson opened this issue May 28, 2021 · 2 comments

Comments

@gotson
Copy link
Owner

gotson commented May 28, 2021

Komga had a public api since the beginning, and despite very few change of contracts, it's been mostly stable so far. It has however some limitations that starts to show.

This is to summarize what will need to be done when bumping the API endpoints to v2.

  • Should not return serialized PageImpl as the contract is not guaranteed
  • collections should always return paged data, never a scalar
  • collections should support unpaged
  • collections should return shallow resources
  • single resource endpoints should return detailed resource
  • when it makes sense, we should break up single resource endpoint in multiple. For example how we get the book and it's pages separately.
  • enum parameters should not leak from the domain model?
  • Library deletion should return 202 Accepted and be done asynchronously, as deletion can take a long time with a huge library
@Bitwolfies

This comment has been minimized.

@gotson

This comment has been minimized.

Repository owner locked and limited conversation to collaborators Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants