Skip to content

Commit 175a8e3

Browse files
committed
remove dataset tool repo as a GPTScript option
Signed-off-by: Grant Linville <[email protected]>
1 parent 955ad9c commit 175a8e3

File tree

4 files changed

+15
-22
lines changed

4 files changed

+15
-22
lines changed

pkg/cli/gptscript.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ type GPTScript struct {
7575
SaveChatStateFile string `usage:"A file to save the chat state to so that a conversation can be resumed with --chat-state" local:"true"`
7676
DefaultModelProvider string `usage:"Default LLM model provider to use, this will override OpenAI settings"`
7777
GithubEnterpriseHostname string `usage:"The host name for a Github Enterprise instance to enable for remote loading" local:"true"`
78-
DatasetToolRepo string `usage:"The repo to use for dataset tools" default:"github.com/gptscript-ai/datasets" local:"true"`
7978

8079
readData []byte
8180
}
@@ -147,7 +146,6 @@ func (r *GPTScript) NewGPTScriptOpts() (gptscript.Options, error) {
147146
Workspace: r.Workspace,
148147
DisablePromptServer: r.UI,
149148
DefaultModelProvider: r.DefaultModelProvider,
150-
DatasetToolRepo: r.DatasetToolRepo,
151149
}
152150

153151
if r.Confirm {

pkg/gptscript/gptscript.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ type Options struct {
5151
CredentialContexts []string
5252
Quiet *bool
5353
Workspace string
54-
DatasetToolRepo string
5554
DisablePromptServer bool
5655
Env []string
5756
}
@@ -67,7 +66,6 @@ func Complete(opts ...Options) Options {
6766
result.CredentialContexts = opt.CredentialContexts
6867
result.Quiet = types.FirstSet(opt.Quiet, result.Quiet)
6968
result.Workspace = types.FirstSet(opt.Workspace, result.Workspace)
70-
result.DatasetToolRepo = types.FirstSet(opt.DatasetToolRepo, result.DatasetToolRepo)
7169
result.Env = append(result.Env, opt.Env...)
7270
result.DisablePromptServer = types.FirstSet(opt.DisablePromptServer, result.DisablePromptServer)
7371
result.DefaultModelProvider = types.FirstSet(opt.DefaultModelProvider, result.DefaultModelProvider)

pkg/sdkserver/datasets.go

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -27,16 +27,19 @@ func (r datasetRequest) validate(requireInput bool) error {
2727

2828
func (r datasetRequest) opts(o gptscript.Options) gptscript.Options {
2929
opts := gptscript.Options{
30-
Cache: o.Cache,
31-
Monitor: o.Monitor,
32-
Runner: o.Runner,
33-
DatasetToolRepo: o.DatasetToolRepo,
34-
Workspace: r.Workspace,
30+
Cache: o.Cache,
31+
Monitor: o.Monitor,
32+
Runner: o.Runner,
33+
Workspace: r.Workspace,
3534
}
35+
return opts
36+
}
37+
38+
func (r datasetRequest) getToolRepo() string {
3639
if r.DatasetToolRepo != "" {
37-
opts.DatasetToolRepo = r.DatasetToolRepo
40+
return r.DatasetToolRepo
3841
}
39-
return opts
42+
return "github.com/gptscript-ai/datasets"
4043
}
4144

4245
func (s *server) listDatasets(w http.ResponseWriter, r *http.Request) {
@@ -59,7 +62,7 @@ func (s *server) listDatasets(w http.ResponseWriter, r *http.Request) {
5962
return
6063
}
6164

62-
prg, err := loader.Program(r.Context(), "List Datasets from "+s.gptscriptOpts.DatasetToolRepo, "", loader.Options{
65+
prg, err := loader.Program(r.Context(), "List Datasets from "+req.getToolRepo(), "", loader.Options{
6366
Cache: g.Cache,
6467
})
6568

@@ -120,7 +123,7 @@ func (s *server) createDataset(w http.ResponseWriter, r *http.Request) {
120123
return
121124
}
122125

123-
prg, err := loader.Program(r.Context(), "Create Dataset from "+s.gptscriptOpts.DatasetToolRepo, "", loader.Options{
126+
prg, err := loader.Program(r.Context(), "Create Dataset from "+req.getToolRepo(), "", loader.Options{
124127
Cache: g.Cache,
125128
})
126129

@@ -189,7 +192,7 @@ func (s *server) addDatasetElement(w http.ResponseWriter, r *http.Request) {
189192
return
190193
}
191194

192-
prg, err := loader.Program(r.Context(), "Add Element from "+s.gptscriptOpts.DatasetToolRepo, "", loader.Options{
195+
prg, err := loader.Program(r.Context(), "Add Element from "+req.getToolRepo(), "", loader.Options{
193196
Cache: g.Cache,
194197
})
195198
if err != nil {
@@ -248,7 +251,7 @@ func (s *server) listDatasetElements(w http.ResponseWriter, r *http.Request) {
248251
return
249252
}
250253

251-
prg, err := loader.Program(r.Context(), "List Elements from "+s.gptscriptOpts.DatasetToolRepo, "", loader.Options{
254+
prg, err := loader.Program(r.Context(), "List Elements from "+req.getToolRepo(), "", loader.Options{
252255
Cache: g.Cache,
253256
})
254257
if err != nil {
@@ -311,7 +314,7 @@ func (s *server) getDatasetElement(w http.ResponseWriter, r *http.Request) {
311314
return
312315
}
313316

314-
prg, err := loader.Program(r.Context(), "Get Element from "+s.gptscriptOpts.DatasetToolRepo, "", loader.Options{
317+
prg, err := loader.Program(r.Context(), "Get Element from "+req.getToolRepo(), "", loader.Options{
315318
Cache: g.Cache,
316319
})
317320
if err != nil {

pkg/sdkserver/server.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@ import (
2323
"github.com/rs/cors"
2424
)
2525

26-
const defaultDatasetToolRepo = "github.com/gptscript-ai/datasets"
27-
2826
type Options struct {
2927
gptscript.Options
3028

@@ -167,9 +165,5 @@ func complete(opts ...Options) Options {
167165
result.ListenAddress = "127.0.0.1:0"
168166
}
169167

170-
if result.DatasetToolRepo == "" {
171-
result.DatasetToolRepo = defaultDatasetToolRepo
172-
}
173-
174168
return result
175169
}

0 commit comments

Comments
 (0)