8332786: When dumping static CDS archives, explicitly assert that we don't use a CDS archive

tstuefe · tstuefe · commit 7b894bc4afa9 · 2024-07-04T05:44:44.000Z
Reviewed-by: iklam, dholmes
diff --git a/src/hotspot/share/cds/metaspaceShared.cpp b/src/hotspot/share/cds/metaspaceShared.cpp
@@ -510,6 +510,8 @@ char* VM_PopulateDumpSharedSpace::dump_read_only_tables() {
 }
 
 void VM_PopulateDumpSharedSpace::doit() {
+  guarantee(!CDSConfig::is_using_archive(), "We should not be using an archive when we dump");
+
   DEBUG_ONLY(SystemDictionaryShared::NoClassLoadingMark nclm);
 
   FileMapInfo::check_nonempty_dir_in_shared_path_table();

Original file line number	Diff line number	Diff line change
`@@ -510,6 +510,8 @@ char* VM_PopulateDumpSharedSpace::dump_read_only_tables() {`
`510`	`510`	`}`
`511`	`511`
`512`	`512`	`void VM_PopulateDumpSharedSpace::doit() {`
	`513`	`+ guarantee(!CDSConfig::is_using_archive(), "We should not be using an archive when we dump");`
	`514`	`+`
`513`	`515`	`DEBUG_ONLY(SystemDictionaryShared::NoClassLoadingMark nclm);`
`514`	`516`
`515`	`517`	`FileMapInfo::check_nonempty_dir_in_shared_path_table();`