Skip to content

Commit dbbf8ff

Browse files
committed
Fix MethodSourceTests for JUnit 5.11.0
1 parent b0a8537 commit dbbf8ff

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

.github/workflows/test-junit-platform-native.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
strategy:
2727
fail-fast: false
2828
matrix:
29-
java-version: [ 17 ]
29+
java-version: [ 17, 23 ]
3030
os: [ ubuntu-20.04 ]
3131
steps:
3232
- name: "☁️ Checkout repository"

common/junit-platform-native/src/test/java/org/graalvm/junit/jupiter/MethodSourceTests.java

+8
Original file line numberDiff line numberDiff line change
@@ -78,12 +78,17 @@ protected static void addExpectedArgs(int a, int b) {
7878
protected static void traceArgs(int a, int b) {
7979
actualArgs.add(new int[]{a, b});
8080
}
81+
82+
protected static void clearPreviousExpectedArgs() {
83+
expectedArgs.clear();
84+
}
8185
}
8286

8387
public static class EmptyMethodSourceTests extends ArgumentTestBase {
8488

8589
@BeforeAll
8690
public static void setup() {
91+
clearPreviousExpectedArgs();
8792
addExpectedArgs(1, 5);
8893
addExpectedArgs(7, 12);
8994
}
@@ -106,6 +111,7 @@ public static class SameClassMethodSourceTests extends ArgumentTestBase {
106111

107112
@BeforeAll
108113
public static void setup() {
114+
clearPreviousExpectedArgs();
109115
addExpectedArgs(31, 32);
110116
addExpectedArgs(1, 3);
111117
}
@@ -128,6 +134,7 @@ public static class OtherClassMethodSourceTests extends ArgumentTestBase {
128134

129135
@BeforeAll
130136
public static void setup() {
137+
clearPreviousExpectedArgs();
131138
addExpectedArgs(33, 35);
132139
addExpectedArgs(99, 1);
133140
}
@@ -143,6 +150,7 @@ public static class CombinedMethodSourceTests extends ArgumentTestBase {
143150

144151
@BeforeAll
145152
public static void setup() {
153+
clearPreviousExpectedArgs();
146154
addExpectedArgs(33, 35);
147155
addExpectedArgs(99, 1);
148156
addExpectedArgs(31, 32);

native-maven-plugin/src/main/java/org/graalvm/buildtools/maven/NativeTestMojo.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ private void runNativeTests(Path executable) throws MojoExecutionException {
219219
throw new MojoExecutionException("Failed creating xml output directory");
220220
}
221221

222-
Path testIdsLocation = outputDirectory.toPath().resolve("test-ids");
222+
Path testIdsLocation = Path.of(NativeExtension.testIdsDirectory(outputDirectory.getAbsolutePath()));
223223
if (!testIdsLocation.toFile().exists()) {
224224
throw new MojoExecutionException("Test-ids not available under target/test-ids");
225225
}

0 commit comments

Comments
 (0)