Skip to content
This repository was archived by the owner on Jan 15, 2024. It is now read-only.

Commit d093362

Browse files
author
Aaron Godin
committed
Add string constants for resource types
1 parent 8df20bf commit d093362

6 files changed

+44
-34
lines changed

‎dashboard_permissions.go

+8-8
Original file line numberDiff line numberDiff line change
@@ -60,18 +60,18 @@ func (c *Client) UpdateDashboardPermissionsByUID(uid string, items *PermissionIt
6060
}
6161

6262
func (c *Client) ListDashboardResourcePermissions(ident ResourceIdent) ([]*ResourcePermission, error) {
63-
return c.listResourcePermissions("dashboards", ident)
63+
return c.listResourcePermissions(DashboardsResource, ident)
6464
}
6565

6666
func (c *Client) SetDashboardResourcePermissions(ident ResourceIdent, body SetResourcePermissionsBody) (*SetResourcePermissionsResponse, error) {
67-
return c.setResourcePermissions("dashboards", ident, body)
67+
return c.setResourcePermissions(DashboardsResource, ident, body)
6868
}
6969

7070
func (c *Client) SetUserDashboardResourcePermissions(ident ResourceIdent, userID int64, permission string) (*SetResourcePermissionsResponse, error) {
7171
return c.setResourcePermissionByAssignment(
72-
"dashboards",
72+
DashboardsResource,
7373
ident,
74-
"users",
74+
UsersResource,
7575
ResourceID(userID),
7676
SetResourcePermissionBody{
7777
Permission: SetResourcePermissionItem{
@@ -84,9 +84,9 @@ func (c *Client) SetUserDashboardResourcePermissions(ident ResourceIdent, userID
8484

8585
func (c *Client) SetTeamDashboardResourcePermissions(ident ResourceIdent, teamID int64, permission string) (*SetResourcePermissionsResponse, error) {
8686
return c.setResourcePermissionByAssignment(
87-
"dashboards",
87+
DashboardsResource,
8888
ident,
89-
"teams",
89+
TeamsResource,
9090
ResourceID(teamID),
9191
SetResourcePermissionBody{
9292
Permission: SetResourcePermissionItem{
@@ -99,9 +99,9 @@ func (c *Client) SetTeamDashboardResourcePermissions(ident ResourceIdent, teamID
9999

100100
func (c *Client) SetBuiltInRoleDashboardResourcePermissions(ident ResourceIdent, builtInRole string, permission string) (*SetResourcePermissionsResponse, error) {
101101
return c.setResourcePermissionByAssignment(
102-
"dashboards",
102+
DashboardsResource,
103103
ident,
104-
"builtInRoles",
104+
BuiltInRolesResource,
105105
ResourceUID(builtInRole),
106106
SetResourcePermissionBody{
107107
Permission: SetResourcePermissionItem{

‎datasource_permissions.go

+8-8
Original file line numberDiff line numberDiff line change
@@ -98,18 +98,18 @@ func (c *Client) RemoveDatasourcePermission(id, permissionID int64) error {
9898
}
9999

100100
func (c *Client) ListDatasourceResourcePermissions(ident ResourceIdent) ([]*ResourcePermission, error) {
101-
return c.listResourcePermissions("datasources", ident)
101+
return c.listResourcePermissions(DatasourcesResource, ident)
102102
}
103103

104104
func (c *Client) SetDatasourceResourcePermissions(ident ResourceIdent, body SetResourcePermissionsBody) (*SetResourcePermissionsResponse, error) {
105-
return c.setResourcePermissions("datasources", ident, body)
105+
return c.setResourcePermissions(DatasourcesResource, ident, body)
106106
}
107107

108108
func (c *Client) SetUserDatasourceResourcePermissions(ident ResourceIdent, userID int64, permission string) (*SetResourcePermissionsResponse, error) {
109109
return c.setResourcePermissionByAssignment(
110-
"datasources",
110+
DatasourcesResource,
111111
ident,
112-
"users",
112+
UsersResource,
113113
ResourceID(userID),
114114
SetResourcePermissionBody{
115115
Permission: SetResourcePermissionItem{
@@ -122,9 +122,9 @@ func (c *Client) SetUserDatasourceResourcePermissions(ident ResourceIdent, userI
122122

123123
func (c *Client) SetTeamDatasourceResourcePermissions(ident ResourceIdent, teamID int64, permission string) (*SetResourcePermissionsResponse, error) {
124124
return c.setResourcePermissionByAssignment(
125-
"datasources",
125+
DatasourcesResource,
126126
ident,
127-
"teams",
127+
TeamsResource,
128128
ResourceID(teamID),
129129
SetResourcePermissionBody{
130130
Permission: SetResourcePermissionItem{
@@ -137,9 +137,9 @@ func (c *Client) SetTeamDatasourceResourcePermissions(ident ResourceIdent, teamI
137137

138138
func (c *Client) SetBuiltInRoleDatasourceResourcePermissions(ident ResourceIdent, builtInRole string, permission string) (*SetResourcePermissionsResponse, error) {
139139
return c.setResourcePermissionByAssignment(
140-
"datasources",
140+
DatasourcesResource,
141141
ident,
142-
"builtInRoles",
142+
BuiltInRolesResource,
143143
ResourceUID(builtInRole),
144144
SetResourcePermissionBody{
145145
Permission: SetResourcePermissionItem{

‎folder_permissions.go

+8-8
Original file line numberDiff line numberDiff line change
@@ -64,18 +64,18 @@ func (c *Client) UpdateFolderPermissions(fid string, items *PermissionItems) err
6464
}
6565

6666
func (c *Client) ListFolderResourcePermissions(ident ResourceIdent) ([]*ResourcePermission, error) {
67-
return c.listResourcePermissions("folders", ident)
67+
return c.listResourcePermissions(FoldersResource, ident)
6868
}
6969

7070
func (c *Client) SetFolderResourcePermissions(ident ResourceIdent, body SetResourcePermissionsBody) (*SetResourcePermissionsResponse, error) {
71-
return c.setResourcePermissions("folders", ident, body)
71+
return c.setResourcePermissions(FoldersResource, ident, body)
7272
}
7373

7474
func (c *Client) SetUserFolderResourcePermissions(ident ResourceIdent, userID int64, permission string) (*SetResourcePermissionsResponse, error) {
7575
return c.setResourcePermissionByAssignment(
76-
"folders",
76+
FoldersResource,
7777
ident,
78-
"users",
78+
UsersResource,
7979
ResourceID(userID),
8080
SetResourcePermissionBody{
8181
Permission: SetResourcePermissionItem{
@@ -88,9 +88,9 @@ func (c *Client) SetUserFolderResourcePermissions(ident ResourceIdent, userID in
8888

8989
func (c *Client) SetTeamFolderResourcePermissions(ident ResourceIdent, teamID int64, permission string) (*SetResourcePermissionsResponse, error) {
9090
return c.setResourcePermissionByAssignment(
91-
"folders",
91+
FoldersResource,
9292
ident,
93-
"teams",
93+
TeamsResource,
9494
ResourceID(teamID),
9595
SetResourcePermissionBody{
9696
Permission: SetResourcePermissionItem{
@@ -103,9 +103,9 @@ func (c *Client) SetTeamFolderResourcePermissions(ident ResourceIdent, teamID in
103103

104104
func (c *Client) SetBuiltInRoleFolderResourcePermissions(ident ResourceIdent, builtInRole string, permission string) (*SetResourcePermissionsResponse, error) {
105105
return c.setResourcePermissionByAssignment(
106-
"folders",
106+
FoldersResource,
107107
ident,
108-
"builtInRoles",
108+
BuiltInRolesResource,
109109
ResourceUID(builtInRole),
110110
SetResourcePermissionBody{
111111
Permission: SetResourcePermissionItem{

‎resource.go

+10
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,16 @@ import (
55
"strconv"
66
)
77

8+
const (
9+
DashboardsResource = "dashboards"
10+
DatasourcesResource = "datasources"
11+
FoldersResource = "folders"
12+
ServiceAccountsResource = "serviceaccounts"
13+
TeamsResource = "teams"
14+
UsersResource = "users"
15+
BuiltInRolesResource = "builtInRoles"
16+
)
17+
818
// ResourceIdent represents anything that can be considered a resource identifier.
919
type ResourceIdent interface {
1020
fmt.Stringer

‎service_account_permissions.go

+6-6
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
package gapi
22

33
func (c *Client) ListServiceAccountResourcePermissions(ident ResourceIdent) ([]*ResourcePermission, error) {
4-
return c.listResourcePermissions("serviceaccounts", ident)
4+
return c.listResourcePermissions(ServiceAccountsResource, ident)
55
}
66

77
func (c *Client) SetServiceAccountResourcePermissions(ident ResourceIdent, body SetResourcePermissionsBody) (*SetResourcePermissionsResponse, error) {
8-
return c.setResourcePermissions("serviceaccounts", ident, body)
8+
return c.setResourcePermissions(ServiceAccountsResource, ident, body)
99
}
1010

1111
func (c *Client) SetUserServiceAccountResourcePermissions(ident ResourceIdent, userID int64, permission string) (*SetResourcePermissionsResponse, error) {
1212
return c.setResourcePermissionByAssignment(
13-
"serviceaccounts",
13+
ServiceAccountsResource,
1414
ident,
15-
"users",
15+
UsersResource,
1616
ResourceID(userID),
1717
SetResourcePermissionBody{
1818
Permission: SetResourcePermissionItem{
@@ -25,9 +25,9 @@ func (c *Client) SetUserServiceAccountResourcePermissions(ident ResourceIdent, u
2525

2626
func (c *Client) SetTeamServiceAccountResourcePermissions(ident ResourceIdent, teamID int64, permission string) (*SetResourcePermissionsResponse, error) {
2727
return c.setResourcePermissionByAssignment(
28-
"serviceaccounts",
28+
ServiceAccountsResource,
2929
ident,
30-
"teams",
30+
TeamsResource,
3131
ResourceID(teamID),
3232
SetResourcePermissionBody{
3333
Permission: SetResourcePermissionItem{

‎team_permissions.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
package gapi
22

33
func (c *Client) ListTeamResourcePermissions(ident ResourceIdent) ([]*ResourcePermission, error) {
4-
return c.listResourcePermissions("teams", ident)
4+
return c.listResourcePermissions(TeamsResource, ident)
55
}
66

77
func (c *Client) SetTeamResourcePermissions(ident ResourceIdent, body SetResourcePermissionsBody) (*SetResourcePermissionsResponse, error) {
8-
return c.setResourcePermissions("teams", ident, body)
8+
return c.setResourcePermissions(TeamsResource, ident, body)
99
}
1010

1111
func (c *Client) SetUserTeamResourcePermissions(ident ResourceIdent, userID int64, permission string) (*SetResourcePermissionsResponse, error) {
1212
return c.setResourcePermissionByAssignment(
13-
"teams",
13+
TeamsResource,
1414
ident,
15-
"users",
15+
UsersResource,
1616
ResourceID(userID),
1717
SetResourcePermissionBody{
1818
Permission: SetResourcePermissionItem{

0 commit comments

Comments
 (0)