Skip to content

Conversation

@narqo
Copy link
Contributor

@narqo narqo commented Sep 18, 2025

What this PR does

Following #12411 #12624, etc

Here I'm adding a new documentation piece, that outlines the setup process of running a new Mimir cluster under the ingest storage architecture with Jsonnet.

@narqo narqo requested review from a team and tacole02 as code owners September 18, 2025 13:48
@narqo narqo added the changelog-not-needed PRs that don't need a CHANGELOG.md entry label Sep 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2025

💻 Deploy preview deleted.

@narqo narqo force-pushed the vldmr/mimir-3-docs-kafka branch from e0bc9d6 to 85a3659 Compare September 18, 2025 13:55
@narqo narqo requested a review from Copilot September 18, 2025 18:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive documentation for configuring Grafana Mimir's ingest storage architecture using Jsonnet, following recent PRs that implemented this functionality.

  • Introduces a new documentation file explaining how to enable and configure ingest storage
  • Provides Jsonnet configuration examples for basic setup and Kafka customization
  • Includes important warnings about migration considerations and requirements

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dimitarvdimitrov dimitarvdimitrov self-requested a review September 29, 2025 17:08
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want to mention the alerts and dashboard toggles in the mixin that they can use for ingest storage?

this looks good, but I think a helm guide will be much more useful

Copy link
Contributor

@tacole02 tacole02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good. Thanks so much for working on all of these setup topics, @narqo !

narqo and others added 4 commits October 2, 2025 13:45
Signed-off-by: Vladimir Varankin <[email protected]>
@narqo
Copy link
Contributor Author

narqo commented Oct 2, 2025

@dimitarvdimitrov

do you want to mention the alerts and dashboard toggles in the mixin that they can use for ingest storage?

Do you refer to any particular dashboards? I don't think tuning the mixins should be here — there is a dedicated section of the site about "Monitor Grafana Mimir", that talks about how to install the mixin, what dashboards are there, etc. I don't see any existing documents under the "Deploy with Jsonnet and Tanka" mention the mixins.

@narqo
Copy link
Contributor Author

narqo commented Oct 2, 2025

I think a helm guide will be much more useful

Helm guide is a separate subsection on the site. It was already updated with basic details about the ingest storage.

@narqo narqo requested a review from dimitarvdimitrov October 2, 2025 12:03
@tacole02
Copy link
Contributor

tacole02 commented Oct 2, 2025

Do you refer to any particular dashboards? I don't think tuning the mixins should be here — there is a dedicated section of the site about "Monitor Grafana Mimir", that talks about how to install the mixin, what dashboards are there, etc. I don't see any existing documents under the "Deploy with Jsonnet and Tanka" mention the mixins.

I agree that this information shouldn't be here. @dimitarvdimitrov are there any architecture-specific considerations in the mixin? If so, we should probably call that out in Monitor Grafana Mimir.

@dimitarvdimitrov
Copy link
Contributor

architecture-specific considerations in the mixin

i think the only config would be these two toggles

// Show panels that use queries for "ingest storage" ingestion (distributor -> Kafka, Kafka -> ingesters)
show_ingest_storage_panels: false,

// Whether alerts for experimental ingest storage are enabled.
ingest_storage_enabled: true,

@narqo narqo merged commit d075d7b into main Oct 8, 2025
39 checks passed
@narqo narqo deleted the vldmr/mimir-3-docs-kafka branch October 8, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-not-needed PRs that don't need a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants