fix: handle logger.Log error return values in ICMP prober

Author: d0ugal

internal/prober/icmp/icmp_impl.go

@@ -109,11 +109,11 @@ func probeICMP(ctx context.Context, target string, module Module, registry *prom
 			hopLimitGauge.Set(float64(pkt.TTL))
 		}
 
-		logger.Log("level", "info", "msg", "Found matching reply packet", "seq", strconv.Itoa(pkt.Seq))
+		_ = logger.Log("level", "info", "msg", "Found matching reply packet", "seq", strconv.Itoa(pkt.Seq))
 	}
 
 	pinger.OnDuplicateRecv = func(pkt *ping.Packet) {
-		logger.Log("level", "info", "msg", "Duplicate packet received", "seq", strconv.Itoa(pkt.Seq))
+		_ = logger.Log("level", "info", "msg", "Duplicate packet received", "seq", strconv.Itoa(pkt.Seq))
 	}
 
 	pinger.OnFinish = func(stats *ping.Statistics) {
@@ -124,7 +124,7 @@ func probeICMP(ctx context.Context, target string, module Module, registry *prom
 		durationStddevGauge.Set(stats.StdDevRtt.Seconds())
 		packetsSentGauge.Set(float64(stats.PacketsSent))
 		packetsReceivedGauge.Set(float64(stats.PacketsRecv))
-		logger.Log("level", "info", "msg", "Probe finished", "packets_sent", stats.PacketsSent, "packets_received", stats.PacketsRecv)
+		_ = logger.Log("level", "info", "msg", "Probe finished", "packets_sent", stats.PacketsSent, "packets_received", stats.PacketsRecv)
 	}
 
 	pinger.SetDoNotFragment(module.ICMP.DontFragment)
@@ -142,10 +142,10 @@ func probeICMP(ctx context.Context, target string, module Module, registry *prom
 
 	setupStart = time.Now()
 
-	logger.Log("level", "info", "msg", "Creating socket")
+	_ = logger.Log("level", "info", "msg", "Creating socket")
 
 	if err := pinger.RunWithContext(ctx); err != nil {
-		logger.Log("level", "info", "msg", "failed to run ping", "err", err.Error())
+		_ = logger.Log("level", "info", "msg", "failed to run ping", "err", err.Error())
 		return false, 0
 	}
 

internal/prober/icmp/utils.go

@@ -58,7 +58,7 @@ func chooseProtocol(ctx context.Context, ipProtocol string, fallbackIPProtocol b
 		fallbackProtocol = "ip6"
 	}
 
-	logger.Log("level", "info", "msg", "Resolving target address", "ip_protocol", ipProtocol)
+	_ = logger.Log("level", "info", "msg", "Resolving target address", "ip_protocol", ipProtocol)
 	resolveStart := time.Now()
 
 	defer func() {
@@ -73,13 +73,13 @@ func chooseProtocol(ctx context.Context, ipProtocol string, fallbackIPProtocol b
 			ips, err := resolver.LookupIP(ctx, ipProtocol, target)
 			if err == nil {
 				for _, ip := range ips {
-					logger.Log("level", "info", "msg", "Resolved target address", "ip", ip.String())
+					_ = logger.Log("level", "info", "msg", "Resolved target address", "ip", ip.String())
 					probeIPProtocolGauge.Set(protocolToGauge[ipProtocol])
 					probeIPAddrHash.Set(ipHash(ip))
 					return &net.IPAddr{IP: ip}, lookupTime, nil
 				}
 			}
-			logger.Log("level", "warn", "msg", "Resolution with IP protocol failed", "err", err)
+			_ = logger.Log("level", "warn", "msg", "Resolution with IP protocol failed", "err", err)
 
 			if isRetryableError(err) {
 				continue
@@ -90,7 +90,7 @@ func chooseProtocol(ctx context.Context, ipProtocol string, fallbackIPProtocol b
 
 		ips, err := resolver.LookupIPAddr(ctx, target)
 		if err != nil {
-			logger.Log("level", "warn", "msg", "Resolution with IP protocol failed", "err", err)
+			_ = logger.Log("level", "warn", "msg", "Resolution with IP protocol failed", "err", err)
 
 			if isRetryableError(err) {
 				continue
@@ -105,7 +105,7 @@ func chooseProtocol(ctx context.Context, ipProtocol string, fallbackIPProtocol b
 			switch ipProtocol {
 			case "ip4":
 				if ip.IP.To4() != nil {
-					logger.Log("level", "info", "msg", "Resolved target address", "ip", ip.String())
+					_ = logger.Log("level", "info", "msg", "Resolved target address", "ip", ip.String())
 					probeIPProtocolGauge.Set(4)
 					probeIPAddrHash.Set(ipHash(ip.IP))
 					return &ip, lookupTime, nil
@@ -116,7 +116,7 @@ func chooseProtocol(ctx context.Context, ipProtocol string, fallbackIPProtocol b
 
 			case "ip6":
 				if ip.IP.To4() == nil {
-					logger.Log("level", "info", "msg", "Resolved target address", "ip", ip.String())
+					_ = logger.Log("level", "info", "msg", "Resolved target address", "ip", ip.String())
 					probeIPProtocolGauge.Set(6)
 					probeIPAddrHash.Set(ipHash(ip.IP))
 					return &ip, lookupTime, nil
@@ -129,7 +129,7 @@ func chooseProtocol(ctx context.Context, ipProtocol string, fallbackIPProtocol b
 
 		// Unable to find ip and no fallback set.
 		if fallbackIdx == -1 || !fallbackIPProtocol {
-			logger.Log("level", "error", "msg", "unable to find ip; no fallback")
+			_ = logger.Log("level", "error", "msg", "unable to find ip; no fallback")
 			break
 		}
 
@@ -141,7 +141,7 @@ func chooseProtocol(ctx context.Context, ipProtocol string, fallbackIPProtocol b
 		}
 		fallback := ips[fallbackIdx]
 		probeIPAddrHash.Set(ipHash(fallback.IP))
-		logger.Log("level", "info", "msg", "Resolved target address", "ip", fallback.String())
+		_ = logger.Log("level", "info", "msg", "Resolved target address", "ip", fallback.String())
 		return &fallback, lookupTime, nil
 	}