fix: rename misleading custom error name (OZ SR-03)

Signed-off-by: Tomás Migone <[email protected]>

Author: tmigone

packages/horizon/contracts/interfaces/internal/IHorizonStakingMain.sol

@@ -510,6 +510,11 @@ interface IHorizonStakingMain {
      */
     error HorizonStakingLegacySlashFailed();
 
+    /**
+     * @notice Thrown when there attempting to slash a provision with no tokens to slash.
+     */
+    error HorizonStakingNoTokensToSlash();
+
     // -- Functions --
 
     /**

packages/horizon/contracts/staking/HorizonStaking.sol

@@ -410,7 +410,7 @@ contract HorizonStaking is HorizonStakingBase, IHorizonStakingMain {
         Provision storage prov = _provisions[serviceProvider][verifier];
         DelegationPoolInternal storage pool = _getDelegationPool(serviceProvider, verifier);
         uint256 tokensProvisionTotal = prov.tokens + pool.tokens;
-        require(tokensProvisionTotal != 0, HorizonStakingInsufficientTokens(tokensProvisionTotal, tokens));
+        require(tokensProvisionTotal != 0, HorizonStakingNoTokensToSlash());
 
         uint256 tokensToSlash = MathUtils.min(tokens, tokensProvisionTotal);
 

packages/horizon/test/staking/slash/slash.t.sol

@@ -97,9 +97,7 @@ contract HorizonStakingSlashTest is HorizonStakingTest {
     function testSlash_RevertWhen_NoProvision(uint256 tokens, uint256 slashTokens) public useIndexer useStake(tokens) {
         vm.assume(slashTokens > 0);
         bytes memory expectedError = abi.encodeWithSelector(
-            IHorizonStakingMain.HorizonStakingInsufficientTokens.selector,
-            0,
-            slashTokens
+            IHorizonStakingMain.HorizonStakingNoTokensToSlash.selector
         );
         vm.expectRevert(expectedError);
         vm.startPrank(subgraphDataServiceAddress);