Skip to content

Commit 150947f

Browse files
committed
Disable flaky test. Revert release version bump.
1 parent 62d87b8 commit 150947f

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

graphql/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@
168168
set_default_backend,
169169
)
170170

171-
VERSION = (2, 3, 0, "final", 0)
171+
VERSION = (2, 2, 1, "final", 0)
172172
__version__ = get_version(VERSION)
173173

174174

graphql/execution/tests/test_executor_thread.py

+6-1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
GraphQLSchema,
1212
GraphQLString,
1313
)
14+
from pytest import mark
1415

1516
from ..executors.thread import ThreadExecutor
1617
from .test_mutations import assert_evaluate_mutations_serially
@@ -288,7 +289,11 @@ def handle_results(result):
288289

289290
handle_results(execute(schema, ast, Data(), executor=ThreadExecutor()))
290291

291-
292+
# Disabled because it's flaky
293+
# The culprit lies in the fact that the `ThreadExecutor` incorrectly assumes that
294+
# the `Promise` class is thread-safe.
295+
# See https://git.io/JeA3s
296+
@mark.xfail
292297
def test_evaluates_mutations_serially():
293298
# type: () -> None
294299
assert_evaluate_mutations_serially(executor=ThreadExecutor())

0 commit comments

Comments
 (0)