Skip to content

Commit 168d3bb

Browse files
committed
rename PromiseCanceller to AbortSignalListener
GraphQL-Core has no PromiseCanceller class. Its cancellation mechanism is the with_abort_signal helper, so this only updates the renamed upstream symbol references in the cancellable_iterable comment and renames the abort-signal test file to test_cancellation.py for parity with the renamed cancellation-test.ts. Replicates graphql/graphql-js@c65bd81
1 parent ba64180 commit 168d3bb

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

src/graphql/execution/execute.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -969,9 +969,9 @@ def cancellable_iterable(self, iterable: AsyncIterable[T]) -> AsyncIterable[T]:
969969
970970
When the abort signal is triggered, any pending ``__anext__`` call returns
971971
immediately by raising the abort reason. This mirrors the JavaScript
972-
``PromiseCanceller.cancellableIterable``; GraphQL-Core needs no
973-
``PromiseCanceller`` class since :meth:`with_abort_signal` already provides
974-
the cancellation mechanism.
972+
``cancellableIterable``; GraphQL-Core needs no ``AbortSignalListener``
973+
class since :meth:`with_abort_signal` already provides the cancellation
974+
mechanism.
975975
"""
976976
if self.abort_signal is None:
977977
return iterable

0 commit comments

Comments
 (0)