Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type exported as JS breaks imports (v15.x.x branch) #4325

Closed
hackwater opened this issue Jan 13, 2025 · 2 comments · Fixed by #4326
Closed

Type exported as JS breaks imports (v15.x.x branch) #4325

hackwater opened this issue Jan 13, 2025 · 2 comments · Fixed by #4326
Labels
bug

Comments

@hackwater
Copy link

hackwater commented Jan 13, 2025 •
edited
Loading

@enisdenjo This export of GraphQLFormattedError should be prefaced with the type keyword to avoid it exporting as regular JS in your build process: https://github.com/graphql/graphql-js/blob/v15.10.0/src/error/formatError.js
export { formatError, GraphQLFormattedError } from './GraphQLError'; in src/error/formatError.js of the v15 branch for the link-averse.
@hackwater hackwater changed the title Type exported as JS breaks imports Type exported as JS breaks imports (v15.x.x branch) Jan 13, 2025
@enisdenjo
Copy link
Member

Oh right, my bad! I'll fix it soon. Thanks for reporting!

@enisdenjo enisdenjo added the bug label Jan 14, 2025
@enisdenjo enisdenjo mentioned this issue Jan 14, 2025
Merged
enisdenjo added a commit that referenced this issue Jan 14, 2025
@enisdenjo
Re-export GraphQLFormattedError as type (#4326)
7066c2c 
Closes #4325
@enisdenjo
Copy link
Member

Fixed in v15.10.1 with #4326.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-export GraphQLFormattedError as type graphql/graphql-js
2 participants
@hackwater @enisdenjo