update swapi to use GraphiQL 5 with Monaco editor and React 19 #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimaMachina
changed the title
dimaMachina
commented
Jul 10, 2025
benjie
reviewed
Jul 10, 2025
| } | ||
| </script> | ||
| </head> | ||
| <script type="module"> |
There was a problem hiding this comment.
This <script> tag is neither in <body> nor <head>?
There was a problem hiding this comment.
great catch, didn't move lines enough from <body>
benjie
reviewed
Jul 17, 2025
| }); | ||
| } | ||
|
|
||
| const container = document.getElementById('graphiql'); |
There was a problem hiding this comment.
I guess this works despite the call being before the element exists because it's <script type="module"> and there's some imports that cause it to run a tick later?
There was a problem hiding this comment.
Ah it's because <script type="module"> is always deferred.
benjie
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per official example https://github.com/graphql/graphiql/blob/main/examples/graphiql-cdn/index.html
(tested locally)
also include tiny fix of confusing console error
module "@emotion/is-prop-valid" not found, ref graphql/graphiql#4072