Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to ignore comments and discards #89

Open
frankitox opened this issue Mar 28, 2022 · 0 comments
Open

Add options to ignore comments and discards #89

frankitox opened this issue Mar 28, 2022 · 0 comments

Comments

@frankitox
Copy link

Hi 👋!

I have a feature request regarding macro comments and the discard macro reader. I would like to format those and found a TODO comment in the codebase:

(defn ignored-form?
"True if the node at this location is an ignored form."
[zloc]
;; TODO: option for ignoring comments and discards?
(or (ignore-meta? zloc)
(comment-form? zloc)
(discard-macro? zloc)))

I wrote a couple of lines to address it in a fork. Would you be interested in merging something like this? I'll write tests, docs and take any feedback you have about it (I'm not even sure if the approach I chose is any good!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant