Commit d11a78b
committed
build(canvas-wasm): retry past the skia-bindings prebuilt emscripten defect
`BinariesConfig::commit_to_cargo` copies `lib<x>.wasm.a` onto `lib<x>.a` for
every emscripten target, because Skia's wasm GN toolchain emits that suffix
since milestone 148. The published prebuilt archives ship those libraries
already named `lib<x>.a`, so the copy panics on a missing source before
anything is compiled. The library list is derived from the enabled features
rather than from whether ninja ran, so only feature sets pulling in textlayout
or svg are affected — which is exactly this crate's, and exactly the
wasm32-unknown-emscripten combo published for it. Present in every
skia-bindings from 0.97.0 through 0.99.0, so no version choice avoids it.
Seeding the names the build script expects and building again is an identity
operation: it copies each seeded file straight back onto the file it was
copied from, so nothing that gets linked changes. Verified from a clean build
directory — the first attempt panics once, the retry links, and the resulting
module initializes under node with `_init`, `HEAPU8` and `UTF8ToString` all
present, which is what the package's node smoke test asserts.
Forcing a source build instead is not an alternative: Skia m150 wants the
four-argument split-64-bit `glClientWaitSync`, while the pinned emsdk 5.0.0
declares the three-argument `GLuint64` form, and the WebGL interface fails to
compile.
Remove this once commit_to_cargo tolerates an absent `.wasm.a`.1 parent 2197b18 commit d11a78b
1 file changed
Lines changed: 22 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
8 | 26 | | |
9 | 27 | | |
10 | 28 | | |
| |||
88 | 106 | | |
89 | 107 | | |
90 | 108 | | |
91 | | - | |
| 109 | + | |
| 110 | + | |
92 | 111 | | |
93 | 112 | | |
94 | 113 | | |
| |||
99 | 118 | | |
100 | 119 | | |
101 | 120 | | |
102 | | - | |
| 121 | + | |
| 122 | + | |
103 | 123 | | |
104 | 124 | | |
105 | 125 | | |
| |||
0 commit comments